Addressing Issue #999 - [Accessibility] PeoplePicker doesn't have focus border when focused by keyboard#3774
Merged
oengusmacinog-zz merged 2 commits intoJan 24, 2018
Conversation
joschect
approved these changes
Jan 23, 2018
joschect
left a comment
joschect
left a comment
Contributor
There was a problem hiding this comment.
Looks great, thanks for the fix!
Contributor
|
You'll just probably need to update the snaps and include a change file. You can add a change file by running To update the snaps you'll change directories to |
Collaborator
Author
|
added and emulated 'on focus' blue border to picker fields. This involved adding an onFocus variable to BasePicker state and added a control class to input container div |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
Added onFocus state Boolean to BasePicker so a class can control the focus css on the input container div.
Focus areas to test
Checked on Tagpicker, DocumentPicker, and PeoplePicker. I am unsure if there are any other instances but they should all inherit from BasePicker