Skip to content

DatePicker: Fix datePicker overlap with week numbers for RTL#3772

Merged
lorejoh12 merged 2 commits into
microsoft:masterfrom
srikanthreddyk:srk/CalendarDayRTLFix
Jan 23, 2018
Merged

DatePicker: Fix datePicker overlap with week numbers for RTL#3772
lorejoh12 merged 2 commits into
microsoft:masterfrom
srikanthreddyk:srk/CalendarDayRTLFix

Conversation

@srikanthreddyk

@srikanthreddyk srikanthreddyk commented Jan 23, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

Pull request checklist

Description of changes

  1. Added new style showWeekNumbersRTL in Calendar.scss, which just modifies the existing showWeekNumbers such that the borders and margins on the left and right are swapped.
  2. Modified the CalendarDay render method to choose the new style or the old one based on RTL setting.

Before the fix

image

After the fix

image

@srikanthreddyk srikanthreddyk changed the title Srk/calendar day rtl fix DatePicker: Fix datePicker overlap with week numbers for RTL Jan 23, 2018
@lorejoh12

lorejoh12 commented Jan 23, 2018

Copy link
Copy Markdown
Contributor

looks good, thanks for the fix

@lorejoh12 lorejoh12 merged commit ee2299a into microsoft:master Jan 23, 2018
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@johannao76 johannao76 Awaiting requested review from johannao76
1 more reviewer
@lorejoh12 lorejoh12 lorejoh12 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DatePicker: Week numbers overlap with datePicker table for RTL

2 participants

@srikanthreddyk @lorejoh12