Skip to content

ChoiceGroup: Wrap long text for icon and image types.#3761

Merged
lynamemi merged 9 commits into
microsoft:masterfrom
lynamemi:choicegroup-textoverflow
Jan 30, 2018
Merged

ChoiceGroup: Wrap long text for icon and image types.#3761
lynamemi merged 9 commits into
microsoft:masterfrom
lynamemi:choicegroup-textoverflow

Conversation

@lynamemi

Copy link
Copy Markdown
Collaborator

Pull request checklist

Description of changes

  • Text was getting cut off. Now it wraps. Had to adjust line-height and margins a bit so that the descenders don't get cut off.
  • Gave both icon and image types a height and width (previously was only icon) so text wraps the same for both.
  • Added wrapping text to an existing example.

After (for before, see issue):
image

Focus areas to test

(optional)

mikewheaton
mikewheaton previously approved these changes Jan 23, 2018
@mikewheaton mikewheaton dismissed their stale review January 23, 2018 17:48

Reviewed the Screener shots and the spacing doesn't look right.

@lynamemi

Copy link
Copy Markdown
Collaborator Author

@mikewheaton finally got the spacing right 😄

@mikewheaton mikewheaton left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@lynamemi lynamemi merged commit f803269 into microsoft:master Jan 30, 2018
@lynamemi lynamemi deleted the choicegroup-textoverflow branch January 30, 2018 23:27
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ChoiceGroup With Icon] Text overflow when label of choice group item is big

2 participants