Skip to content

Dropdown: Align error message style to TextField and ComboBox#3760

Merged
lynamemi merged 7 commits into
microsoft:masterfrom
lynamemi:dropdown-errormessage
Jan 23, 2018
Merged

Dropdown: Align error message style to TextField and ComboBox#3760
lynamemi merged 7 commits into
microsoft:masterfrom
lynamemi:dropdown-errormessage

Conversation

@lynamemi

Copy link
Copy Markdown
Collaborator

Pull request checklist

Description of changes

  • Error message text styling now aligns with TextField's
  • New example for documentation so we can see this functionality
  • Fixed border color states when there is an error
  • Also fixed border color states for ComboBox and TextField to be consistent, not all states were red, they should be
  • Tweaked some example scss to match patterns we're using with other examples

image

Focus areas to test

(optional)

@lynamemi lynamemi merged commit f2dcf91 into microsoft:master Jan 23, 2018
@lynamemi lynamemi deleted the dropdown-errormessage branch January 23, 2018 18:51
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dropdown errorMessage style inconsistent with TextField errorMessage style

2 participants