[FocusTrapZone]: Fix text selection within FocusTrapZone#3759
Merged
Conversation
jakob101
changed the title
mtennoe
approved these changes
Jan 22, 2018
Member
Author
|
@chaofeng2014 if I make it focusable (tabindex=-1), it gets the blue outline on selection, which makes me use CSS in the focusTrapZone (to make the blue outline disappear until is-focusVisible). That sounded worse to me so I didn't do it. But I'm happy to do that if you think otherwise :) |
Member
Author
|
So basically I reverted a small part of the change #3489 (which made focusTrapZone selectable). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
The forced focus on the root element of FocusTrapZone makes it impossible to select text inside the FocusTrapZone as you can see in this CodePen Try selecting text inside the FocusTrapZone.
Then try removing the call to _onRootFocus in the DevTools.
Focus areas to test
(optional)