SpinButton: Add getClassNames prop to allow complete customization of the component#3753
Conversation
|
|
kysedate
changed the title
kysedate
changed the title
| "changes": [ | ||
| { | ||
| "packageName": "office-ui-fabric-react", | ||
| "comment": "SpinButton: Add getClassNAmes prop to allow complete customization of the component", |
There was a problem hiding this comment.
rather nervous of this change. A better approach would be to avoid the getClassNames approach and use the 6.0 getStyles functional approach. We found that getClassNames required us to come up with every possible permutation of areas and states, whereas a function of state can produce a given set of area classes.
See the ghdocs/styling.md file for more description.
There was a problem hiding this comment.
@dzearing this is another case where we need something that lets us completely override the styling in the 5.0 timeframe for Office Online.
There was a problem hiding this comment.
Should we just move it to getStyles in the 5.0 branch?
|
@montselozanod can you work with @kysedate to see how we can unblock this work? Can we perhaps go straight to the new styling API safely? |
|
@christiango sure!! I'll talk with @kysedate so we can go over this together |
7 participants
Pull request checklist
$ npm run changeDescription of changes
Adding a prop to the Spin Button that allows for a complete override of the fabric styles