Website: Left navigation scroll implementation#3749
Merged
Conversation
lynamemi
requested review from
atneik,
dzearing,
gokunymbus,
micahgodbolt and
mikewheaton
betrue-final-final
approved these changes
Jan 19, 2018
betrue-final-final
left a comment
betrue-final-final
left a comment
Contributor
There was a problem hiding this comment.
I would consider using an on-demand scroll bar. I know that @mikewheaton had some issues about discoverability, but If the content is all the way down the window, and they don't see what they want, the usual case is they tend to move their cursor down there, which would invoke the scroll bar.
mikewheaton
approved these changes
Jan 19, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
After:
(note that the GetStarted page is used here as an example in place of a component page because of nuances of the testing environment)
Focus areas to test
(optional)