Skip to content

refactor(react-divider): refactor divider base hook#35679

Merged
dmytrokirpa merged 3 commits into
microsoft:masterfrom
dmytrokirpa:refactor/react-divider
Jan 21, 2026
Merged

refactor(react-divider): refactor divider base hook#35679
dmytrokirpa merged 3 commits into
microsoft:masterfrom
dmytrokirpa:refactor/react-divider

Conversation

@dmytrokirpa

@dmytrokirpa dmytrokirpa commented Jan 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Previous Behavior

  1. Divider base hook lived in a separate file and useDivider_unstable handled vertical + aria-orientation.
  2. Some custom props (e.g., color) were not forwarded to the root element due to getIntristicElementProps filtering.

New Behavior

  1. Divider base hook is co-located in useDivider.ts and now owns vertical handling and aria-orientation, while useDivider_unstable focuses only on design props
  2. Custom props like color are now forwarded to the root element.

Related Issue(s)

  • Fixes #

@dmytrokirpa dmytrokirpa self-assigned this Jan 20, 2026
@github-actions

github-actions Bot commented Jan 20, 2026

Copy link
Copy Markdown

Pull request demo site: URL

github-actions[bot]
github-actions Bot reviewed Jan 20, 2026
View reviewed changes
Comment thread change/@fluentui-react-divider-56bf4621-acd7-4ec1-8dfb-7bd5cf77a9b5.json
@dmytrokirpa dmytrokirpa force-pushed the refactor/react-divider branch from ac0d407 to aad939a Compare January 20, 2026 14:31
@github-actions

github-actions Bot commented Jan 20, 2026 •
edited
Loading

Copy link
Copy Markdown

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-components
react-components: entire library		 1.287 MB
322.577 kB		 1.287 MB
322.559 kB		 -22 B
-18 B
react-divider
Divider		 20.683 kB
7.609 kB		 17.24 kB
6.246 kB		 -3.443 kB
-1.363 kB
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme		 70.322 kB
20.082 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 237.741 kB
68.697 kB
react-components
react-components: FluentProvider & webLightTheme		 43.621 kB
14.173 kB
react-portal-compat
PortalCompatProvider		 8.386 kB
2.624 kB
react-timepicker-compat
TimePicker		 109.036 kB
36.023 kB
🤖 This report was generated against 61d916bab29e92ff5db81a3fc876a6f3cf73608a

@dmytrokirpa dmytrokirpa marked this pull request as ready for review January 20, 2026 21:35
@dmytrokirpa dmytrokirpa requested a review from a team as a code owner January 20, 2026 21:35
mainframev
mainframev reviewed Jan 21, 2026
View reviewed changes
Comment thread packages/react-components/react-divider/library/src/components/Divider/useDivider.ts Outdated
@dmytrokirpa dmytrokirpa enabled auto-merge (squash) January 21, 2026 15:38
@dmytrokirpa dmytrokirpa merged commit 7f1c7e1 into microsoft:master Jan 21, 2026
12 checks passed
@dmytrokirpa dmytrokirpa mentioned this pull request Mar 23, 2026
Open
1 task
tudorpopams pushed a commit to tudorpopams/fluentui that referenced this pull request Apr 14, 2026
@dmytrokirpa @tudorpopams
refactor(react-divider): refactor divider base hook (microsoft#35679)
50e37b8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments
@mainframev mainframev mainframev approved these changes

Assignees

@dmytrokirpa dmytrokirpa

Labels

Component: Divider Fluent UI react-components (v9)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dmytrokirpa @mainframev