Make ComboBox, ContextualMenu, TeachingBubble support calloutProps.className #3504
Merged
micahgodbolt merged 5 commits intoFeb 13, 2018
Merged
Conversation
kurtcarpenter
commented
Dec 2, 2017
| /> | ||
| ); | ||
|
|
||
| setTimeout(() => { |
Contributor
Author
There was a problem hiding this comment.
This setTimeout is needed due to the calloutProps not being fully propagated on first UI tick. Please let me know if there is a better solution to solve that problem.
micahgodbolt
changed the title
micahgodbolt
approved these changes
Feb 13, 2018
micahgodbolt
left a comment
micahgodbolt
left a comment
Member
There was a problem hiding this comment.
Good catch here. Thanks for the addition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
Previously ComboBox, ContextualMenu, and TeachingBubble failed to honor props.calloutProps.className, resulting in the Callout element not receiving the user-specified class names.
Now these three components are brought in-line with other components such as Dropdown, which merge
.ms-Callout, a component-specific class, and user classes.Focus areas to test
Regression tests present on the three components that verify user-specified class is added to the Callout.