(Architecture Prototype): Adding semantic tokens to FluentProvider typing#32104
Draft
EdDaWord wants to merge 2 commits into
Draft
(Architecture Prototype): Adding semantic tokens to FluentProvider typing#32104EdDaWord wants to merge 2 commits into
EdDaWord wants to merge 2 commits into
Conversation
Collaborator
📊 Bundle size report✅ No changes found |
Collaborator
🕵 fluentui-web-components-v3 No visual regressions between this PR and main |
fabricteam
reviewed
Jul 25, 2024
| @@ -0,0 +1,411 @@ | |||
| export type SemanticTokens = { | |||
Collaborator
There was a problem hiding this comment.
🕵🏾♀️ visual regressions to review in the fluentuiv9 Visual Regression Report
Avatar Converged 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Avatar Converged.badgeMask - RTL.normal.chromium.png | 2 | Changed |
| Avatar Converged.badgeMask.normal.chromium.png | 1 | Changed |
EdDaWord
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Adding semantic to tokens typing. Whereas control tokens are ones we'd ideally under expose because they are "pay-to-play". Control tokens can remain as slots.