Skip to content

chore: normalize target names and target dependency graph to properly utilize cache hits#31926

Merged
Hotell merged 8 commits into
microsoft:masterfrom
Hotell:nx/target-names-normalize
Jul 17, 2024
Merged

chore: normalize target names and target dependency graph to properly utilize cache hits#31926
Hotell merged 8 commits into
microsoft:masterfrom
Hotell:nx/target-names-normalize

Conversation

@Hotell

@Hotell Hotell commented Jul 4, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Previous Behavior

  • tasks/targets are executed in non consistent way ( lage, yarn workspace, yarn run etc )
  • tasks/target names naming might be confusing and doesn't express the real intent of the "verb"
  • obtaining proper measuring/metrics is cumbersome

New Behavior

Related Issue(s)

@github-actions github-actions Bot added this to the July Project Cycle Q3 2024 milestone Jul 4, 2024
@Hotell Hotell changed the title Nx/target names normalize chore: normalize target names and target dependency graph to properly utilize cache hits Jul 4, 2024
@Hotell Hotell mentioned this pull request Jul 4, 2024
Closed
39 tasks
fabricteam
fabricteam reviewed Jul 4, 2024
View reviewed changes
Comment thread .devops/templates/build-test-lint.yml
@fabricteam

fabricteam commented Jul 4, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 636 626 5000
Button mount 321 307 5000
Field mount 1129 1141 5000
FluentProvider mount 714 702 5000
FluentProviderWithTheme mount 82 84 10
FluentProviderWithTheme virtual-rerender 39 34 10
FluentProviderWithTheme virtual-rerender-with-unmount 80 77 10
MakeStyles mount 874 856 50000
Persona mount 1780 1753 5000
SpinButton mount 1410 1375 5000
SwatchPicker mount 1679 1666 5000

@fabricteam

fabricteam commented Jul 4, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

📊 Bundle size report

✅ No changes found

@fabricteam

fabricteam commented Jul 4, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam

fabricteam commented Jul 4, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AttachmentMinimalPerf.default 95 79 1.2:1
DropdownManyItemsPerf.default 409 370 1.11:1
AccordionMinimalPerf.default 92 84 1.1:1
ChatWithPopoverPerf.default 212 192 1.1:1
ListWith60ListItems.default 376 344 1.09:1
ToolbarMinimalPerf.default 572 531 1.08:1
ProviderMinimalPerf.default 208 195 1.07:1
SkeletonMinimalPerf.default 210 196 1.07:1
AnimationMinimalPerf.default 312 295 1.06:1
AvatarMinimalPerf.default 114 108 1.06:1
LoaderMinimalPerf.default 191 181 1.06:1
PortalMinimalPerf.default 88 83 1.06:1
HeaderSlotsPerf.default 482 459 1.05:1
PopupMinimalPerf.default 363 347 1.05:1
SegmentMinimalPerf.default 207 198 1.05:1
TreeMinimalPerf.default 504 481 1.05:1
AlertMinimalPerf.default 170 163 1.04:1
HeaderMinimalPerf.default 214 205 1.04:1
RadioGroupMinimalPerf.default 267 256 1.04:1
IconMinimalPerf.default 389 374 1.04:1
TextMinimalPerf.default 197 189 1.04:1
BoxMinimalPerf.default 199 193 1.03:1
CardMinimalPerf.default 319 310 1.03:1
ChatDuplicateMessagesPerf.default 158 154 1.03:1
InputMinimalPerf.default 565 548 1.03:1
ItemLayoutMinimalPerf.default 731 710 1.03:1
MenuButtonMinimalPerf.default 959 935 1.03:1
TextAreaMinimalPerf.default 307 298 1.03:1
DatepickerMinimalPerf.default 3587 3518 1.02:1
DividerMinimalPerf.default 209 204 1.02:1
GridMinimalPerf.default 187 183 1.02:1
ImageMinimalPerf.default 225 221 1.02:1
LabelMinimalPerf.default 221 217 1.02:1
ListMinimalPerf.default 303 296 1.02:1
TableManyItemsPerf.default 1125 1107 1.02:1
TreeWith60ListItems.default 91 89 1.02:1
VideoMinimalPerf.default 446 438 1.02:1
AttachmentSlotsPerf.default 633 624 1.01:1
ButtonMinimalPerf.default 88 87 1.01:1
ButtonSlotsPerf.default 311 308 1.01:1
DropdownMinimalPerf.default 1442 1434 1.01:1
LayoutMinimalPerf.default 192 191 1.01:1
MenuMinimalPerf.default 516 509 1.01:1
ProviderMergeThemesPerf.default 651 647 1.01:1
ReactionMinimalPerf.default 212 210 1.01:1
SliderMinimalPerf.default 750 742 1.01:1
ChatMinimalPerf.default 426 428 1:1
CheckboxMinimalPerf.default 1152 1150 1:1
DialogMinimalPerf.default 433 433 1:1
EmbedMinimalPerf.default 1869 1866 1:1
FlexMinimalPerf.default 156 156 1:1
FormMinimalPerf.default 229 228 1:1
ListCommonPerf.default 408 407 1:1
ListNestedPerf.default 335 336 1:1
CustomToolbarPrototype.default 1477 1480 1:1
ButtonOverridesMissPerf.default 655 660 0.99:1
SplitButtonMinimalPerf.default 2240 2257 0.99:1
StatusMinimalPerf.default 407 410 0.99:1
TableMinimalPerf.default 234 238 0.98:1
TooltipMinimalPerf.default 1276 1307 0.98:1
CarouselMinimalPerf.default 258 268 0.96:1
RefMinimalPerf.default 105 109 0.96:1
RosterPerf.default 1530 1626 0.94:1

@fabricteam

fabricteam commented Jul 4, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 639 636 5000
Breadcrumb mount 1670 1705 1000
Checkbox mount 1703 1722 5000
CheckboxBase mount 1495 1499 5000
ChoiceGroup mount 3002 2967 5000
ComboBox mount 703 687 1000
CommandBar mount 6720 6702 1000
ContextualMenu mount 14950 14112 1000
DefaultButton mount 805 797 5000
DetailsRow mount 2252 2256 5000
DetailsRowFast mount 2213 2235 5000
DetailsRowNoStyles mount 2063 2080 5000
Dialog mount 2770 2699 1000
DocumentCardTitle mount 234 232 1000
Dropdown mount 1996 2014 5000
FocusTrapZone mount 1146 1175 5000
FocusZone mount 1064 1109 5000
GroupedList mount 42399 43223 2
GroupedList virtual-rerender 20550 20803 2
GroupedList virtual-rerender-with-unmount 52015 52424 2
GroupedListV2 mount 232 224 2
GroupedListV2 virtual-rerender 212 224 2
GroupedListV2 virtual-rerender-with-unmount 231 241 2
IconButton mount 1154 1159 5000
Label mount 336 339 5000
Layer mount 2755 2841 5000
Link mount 416 406 5000
MenuButton mount 982 983 5000
MessageBar mount 21473 21280 5000
Nav mount 2065 2096 1000
OverflowSet mount 782 808 5000
Panel mount 1947 1828 1000
Persona mount 754 761 1000
Pivot mount 921 903 1000
PrimaryButton mount 962 948 5000
Rating mount 4714 4894 5000
SearchBox mount 913 910 5000
Shimmer mount 1893 1932 5000
Slider mount 1390 1371 5000
SpinButton mount 3027 2964 5000
Spinner mount 410 399 5000
SplitButton mount 1845 1857 5000
Stack mount 426 423 5000
StackWithIntrinsicChildren mount 881 874 5000
StackWithTextChildren mount 2774 2786 5000
SwatchColorPicker mount 6536 6493 5000
TagPicker mount 1475 1462 5000
Text mount 405 395 5000
TextField mount 958 957 5000
ThemeProvider mount 873 870 5000
ThemeProvider virtual-rerender 592 605 5000
ThemeProvider virtual-rerender-with-unmount 1298 1311 5000
Toggle mount 629 660 5000
buttonNative mount 205 192 5000

fabricteam
fabricteam reviewed Jul 4, 2024
View reviewed changes
Comment thread .devops/templates/build-test-lint.yml
@mainframev mainframev mentioned this pull request Jul 6, 2024
Closed
2 tasks
@Hotell Hotell force-pushed the nx/target-names-normalize branch from 07daf88 to f6b7c9d Compare July 8, 2024 11:51
Hotell
Hotell commented Jul 8, 2024
View reviewed changes
Comment thread lage.config.js
Hotell
Hotell commented Jul 8, 2024
View reviewed changes
Comment thread package.json Outdated
@Hotell Hotell marked this pull request as ready for review July 8, 2024 16:00
@Hotell Hotell requested review from a team as code owners July 8, 2024 16:00
spmonahan
spmonahan approved these changes Jul 8, 2024
View reviewed changes
Comment thread docs/react-v9/contributing/command-cheat-sheet.md
@marcosmoura marcosmoura requested a review from dmytrokirpa July 9, 2024 14:26
@Hotell Hotell force-pushed the nx/target-names-normalize branch from b14b929 to 3e4ab4a Compare July 16, 2024 15:05
@Hotell
chore(public-docsite-resources): add back build target and docs on ho…
9a2c134 
…w this project is violating our project policies
@fabricteam

fabricteam commented Jul 16, 2024

Copy link
Copy Markdown
Collaborator

🕵 fluentui-web-components-v3 No visual regressions between this PR and main

@Hotell Hotell mentioned this pull request Jul 16, 2024
Closed
2 tasks
@Hotell

Hotell commented Jul 16, 2024

Copy link
Copy Markdown
Contributor Author

note: have enough approvers - once pipeline passes I'll admin merge

@Hotell Hotell merged commit c000808 into microsoft:master Jul 17, 2024
@Hotell Hotell deleted the nx/target-names-normalize branch July 17, 2024 07:54
@Hotell Hotell mentioned this pull request Jul 17, 2024
Merged
@Hotell Hotell mentioned this pull request Aug 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabricteam fabricteam fabricteam left review comments
@dmytrokirpa dmytrokirpa dmytrokirpa approved these changes
@layershifter layershifter layershifter approved these changes
@spmonahan spmonahan spmonahan approved these changes

Assignees

No one assigned

Labels

Area: Build System CI NX: core

Projects

None yet

Milestone

July Project Cycle Q3 2024

Development

Successfully merging this pull request may close these issues.

[Bug]: can't release @fluentui/react-northstar

5 participants

@Hotell @fabricteam @dmytrokirpa @layershifter @spmonahan