Skip to content

bench: repo base#31536

Draft
Hotell wants to merge 8 commits into
microsoft:masterfrom
Hotell:bench/repo-base
Draft

bench: repo base#31536
Hotell wants to merge 8 commits into
microsoft:masterfrom
Hotell:bench/repo-base

Conversation

@Hotell

@Hotell Hotell commented May 31, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Previous Behavior

New Behavior

This is a base branch that managed by v-build, which is used to measure pipeline and targets execution perf.

Related Issue(s)

  • Fixes #

@github-actions github-actions Bot added this to the April Project Cycle Q1 2024 milestone May 31, 2024
@Hotell Hotell changed the title Bench/repo base bench: repo base May 31, 2024
@fabricteam

fabricteam commented May 31, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

🕵 FluentUIV0 No visual regressions between this PR and main

@codesandbox-ci

codesandbox-ci Bot commented May 31, 2024 •
edited
Loading

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@fabricteam

fabricteam commented May 31, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

📊 Bundle size report

✅ No changes found

@fabricteam

fabricteam commented Jun 3, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
FlexMinimalPerf.default 166 148 1.12:1
AccordionMinimalPerf.default 87 80 1.09:1
BoxMinimalPerf.default 204 191 1.07:1
ButtonSlotsPerf.default 324 303 1.07:1
FormMinimalPerf.default 225 211 1.07:1
PortalMinimalPerf.default 91 85 1.07:1
SegmentMinimalPerf.default 201 188 1.07:1
SliderMinimalPerf.default 789 739 1.07:1
MenuMinimalPerf.default 523 494 1.06:1
RosterPerf.default 1625 1535 1.06:1
ReactionMinimalPerf.default 218 205 1.06:1
TextAreaMinimalPerf.default 300 284 1.06:1
AttachmentSlotsPerf.default 658 634 1.04:1
PopupMinimalPerf.default 359 346 1.04:1
ProviderMinimalPerf.default 216 207 1.04:1
AnimationMinimalPerf.default 307 301 1.02:1
ChatWithPopoverPerf.default 198 195 1.02:1
InputMinimalPerf.default 542 532 1.02:1
ItemLayoutMinimalPerf.default 717 706 1.02:1
ListMinimalPerf.default 306 299 1.02:1
ListNestedPerf.default 334 329 1.02:1
LoaderMinimalPerf.default 189 185 1.02:1
ProviderMergeThemesPerf.default 652 639 1.02:1
CustomToolbarPrototype.default 1493 1465 1.02:1
TreeMinimalPerf.default 482 471 1.02:1
AttachmentMinimalPerf.default 85 84 1.01:1
CardMinimalPerf.default 316 312 1.01:1
CarouselMinimalPerf.default 273 269 1.01:1
DatepickerMinimalPerf.default 3542 3506 1.01:1
EmbedMinimalPerf.default 1852 1834 1.01:1
LayoutMinimalPerf.default 202 200 1.01:1
RefMinimalPerf.default 109 108 1.01:1
TextMinimalPerf.default 203 200 1.01:1
ToolbarMinimalPerf.default 542 539 1.01:1
ButtonOverridesMissPerf.default 627 627 1:1
ChatDuplicateMessagesPerf.default 151 151 1:1
CheckboxMinimalPerf.default 1141 1141 1:1
DialogMinimalPerf.default 441 439 1:1
DividerMinimalPerf.default 206 206 1:1
ImageMinimalPerf.default 233 232 1:1
ListWith60ListItems.default 363 364 1:1
MenuButtonMinimalPerf.default 961 963 1:1
TableMinimalPerf.default 236 236 1:1
AvatarMinimalPerf.default 109 110 0.99:1
DropdownMinimalPerf.default 1401 1409 0.99:1
GridMinimalPerf.default 188 190 0.99:1
HeaderMinimalPerf.default 210 213 0.99:1
HeaderSlotsPerf.default 460 463 0.99:1
RadioGroupMinimalPerf.default 260 263 0.99:1
SplitButtonMinimalPerf.default 2214 2236 0.99:1
TableManyItemsPerf.default 1097 1112 0.99:1
VideoMinimalPerf.default 435 440 0.99:1
AlertMinimalPerf.default 148 151 0.98:1
ChatMinimalPerf.default 447 456 0.98:1
ListCommonPerf.default 394 402 0.98:1
StatusMinimalPerf.default 393 401 0.98:1
ButtonMinimalPerf.default 89 92 0.97:1
DropdownManyItemsPerf.default 388 405 0.96:1
IconMinimalPerf.default 363 377 0.96:1
TreeWith60ListItems.default 85 89 0.96:1
LabelMinimalPerf.default 208 219 0.95:1
SkeletonMinimalPerf.default 200 213 0.94:1
TooltipMinimalPerf.default 1274 1352 0.94:1

@Hotell Hotell force-pushed the bench/repo-base branch from 4e53e07 to 0891fbe Compare June 4, 2024 11:11
@fabricteam

fabricteam commented Jun 5, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 640 611 5000
Button mount 300 312 5000
Field mount 1167 1142 5000
FluentProvider mount 709 722 5000
FluentProviderWithTheme mount 91 102 10
FluentProviderWithTheme virtual-rerender 37 40 10
FluentProviderWithTheme virtual-rerender-with-unmount 72 80 10
MakeStyles mount 889 865 50000
Persona mount 1794 1708 5000
SpinButton mount 1431 1390 5000
SwatchPicker mount 1767 1723 5000

@fabricteam

fabricteam commented Jun 5, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 641 635 5000
Breadcrumb mount 1668 1686 1000
Checkbox mount 1692 1693 5000
CheckboxBase mount 1504 1490 5000
ChoiceGroup mount 3028 2983 5000
ComboBox mount 703 679 1000
CommandBar mount 6570 6565 1000
ContextualMenu mount 11666 11727 1000
DefaultButton mount 791 791 5000
DetailsRow mount 2269 2273 5000
DetailsRowFast mount 2281 2316 5000
DetailsRowNoStyles mount 2073 2071 5000
Dialog mount 2816 2671 1000
DocumentCardTitle mount 225 238 1000
Dropdown mount 2001 2024 5000
FocusTrapZone mount 1178 1166 5000
FocusZone mount 1102 1099 5000
GroupedList mount 42430 42529 2
GroupedList virtual-rerender 20720 20594 2
GroupedList virtual-rerender-with-unmount 52444 52288 2
GroupedListV2 mount 223 234 2
GroupedListV2 virtual-rerender 206 210 2
GroupedListV2 virtual-rerender-with-unmount 228 234 2
IconButton mount 1171 1132 5000
Label mount 340 339 5000
Layer mount 2765 2792 5000
Link mount 398 406 5000
MenuButton mount 996 1013 5000
MessageBar mount 21512 21957 5000
Nav mount 2011 2090 1000
OverflowSet mount 817 792 5000
Panel mount 1890 1854 1000
Persona mount 748 752 1000
Pivot mount 911 912 1000
PrimaryButton mount 924 928 5000
Rating mount 4759 4807 5000
SearchBox mount 931 910 5000
Shimmer mount 1935 1951 5000
Slider mount 1352 1357 5000
SpinButton mount 3018 2966 5000
Spinner mount 401 405 5000
SplitButton mount 1900 1886 5000
Stack mount 436 430 5000
StackWithIntrinsicChildren mount 908 879 5000
StackWithTextChildren mount 2832 2792 5000
SwatchColorPicker mount 6507 6562 5000
TagPicker mount 1515 1491 5000
Text mount 401 407 5000
TextField mount 966 935 5000
ThemeProvider mount 877 890 5000
ThemeProvider virtual-rerender 594 612 5000
ThemeProvider virtual-rerender-with-unmount 1302 1352 5000
Toggle mount 634 635 5000
buttonNative mount 188 192 5000

@Hotell Hotell force-pushed the bench/repo-base branch from 4d64245 to e6941d7 Compare June 11, 2024 18:54
@Hotell Hotell mentioned this pull request Jun 28, 2024
Closed
1 task
@Hotell Hotell force-pushed the bench/repo-base branch from e6941d7 to 703e0a6 Compare July 4, 2024 07:58
This was referenced Jul 4, 2024
Merged
Merged
@Hotell Hotell force-pushed the bench/repo-base branch from 83ab40c to 1c0bed5 Compare July 19, 2024 11:51
@fabricteam

fabricteam commented Jul 19, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

🕵 fluentui-web-components-v3 No visual regressions between this PR and main

@fabricteam

fabricteam commented Jul 19, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

🕵 fluentuiv8 No visual regressions between this PR and main

fabricteam
fabricteam reviewed Jul 19, 2024
View reviewed changes
Comment thread .devops/templates/build-test-lint.yml
@@ -7,44 +7,67 @@ steps:
displayName: yarn (install packages)

@fabricteam fabricteam Jul 19, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵🏾‍♀️ visual regressions to review in the fluentuiv9 Visual Regression Report

Avatar Converged 1 screenshots
Image Name Diff(in Pixels) Image Type
Avatar Converged.badgeMask.normal.chromium.png 2 Changed

@Hotell Hotell force-pushed the bench/repo-base branch 2 times, most recently from 9181ea1 to 0ee3af8 Compare July 22, 2024 13:37
@Hotell Hotell force-pushed the bench/repo-base branch from 6a2dea4 to e2ca5fa Compare July 26, 2024 07:31
@layershifter

layershifter commented Aug 13, 2024

Copy link
Copy Markdown
Member

Closing for housekeeping 🏡 Feel free to re-open

@Hotell

Hotell commented Aug 14, 2024

Copy link
Copy Markdown
Contributor Author

@layershifter

I'd like to understand the housekeeping here ?

  • PR drafts should be owner responsibility to close as they please ( they don't affect us in any way )
  • if there is an official process to autoclose "stale" based on agreed patterns then it should be done via automation

FYI: we demoed stats and referenced this branch last month as a go to thing for gathering pipeline metrics.

Please next time communicate these kind of actions in advance with core team. thank you

@Hotell Hotell reopened this Aug 14, 2024
@layershifter

layershifter commented Aug 14, 2024

Copy link
Copy Markdown
Member

PR drafts should be owner responsibility to close as they please ( they don't affect us in any way )
if there is an official process to autoclose "stale" based on agreed patterns then it should be done via automation

I don't think that self-responsibility works in this case. I will propose adding automation to autoclose stale PRs from contributors i.e. people on codeowners list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabricteam fabricteam fabricteam left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Status: Do Not Merge 🚫

Projects

None yet

Milestone

August Project Cycle Q3 2024

Development

Successfully merging this pull request may close these issues.

3 participants

@Hotell @fabricteam @layershifter