Type checking perf/bench/after by Hotell · Pull Request #31066 · microsoft/fluentui

Hotell · 2024-04-16T15:15:28Z

Previous Behavior

New Behavior

Before

After

𝚫 85% FASTER

Related Issue(s)

Fixes #

codesandbox-ci · 2024-04-16T15:27:02Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

fabricteam · 2024-04-16T15:28:13Z

Perf Analysis (`@fluentui/react-components`)

Scenario	Render type	Master Ticks	PR Ticks	Iterations	Status
FluentProviderWithTheme	virtual-rerender	36	36	10	Possible regression

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations	Status
Avatar	mount	631	649	5000
Button	mount	301	302	5000
Field	mount	1099	1127	5000
FluentProvider	mount	701	686	5000
FluentProviderWithTheme	mount	75	82	10
FluentProviderWithTheme	virtual-rerender	36	36	10	Possible regression
FluentProviderWithTheme	virtual-rerender-with-unmount	73	70	10
MakeStyles	mount	852	867	50000
Persona	mount	1734	1717	5000
SpinButton	mount	1406	1362	5000
SwatchPicker	mount	1532	1485	5000

fabricteam · 2024-04-16T15:28:37Z

📊 Bundle size report

Package & Exports	Baseline (minified/GZIP)	PR	Change
`library` Accordion (including children components)	`0 B` `0 B`	`100.94 kB` `30.575 kB`	🆕 New entry
`library` Alert	`0 B` `0 B`	`83.739 kB` `23.476 kB`	🆕 New entry
`library` Avatar	`0 B` `0 B`	`50.177 kB` `15.946 kB`	🆕 New entry
`library` AvatarGroup	`0 B` `0 B`	`19.702 kB` `7.794 kB`	🆕 New entry
`library` AvatarGroupItem	`0 B` `0 B`	`64.829 kB` `20.271 kB`	🆕 New entry
`library` Badge	`0 B` `0 B`	`26.907 kB` `8.732 kB`	🆕 New entry
`library` Button	`0 B` `0 B`	`39.515 kB` `11.172 kB`	🆕 New entry
`library` react-components: Button, FluentProvider & webLightTheme	`0 B` `0 B`	`71.106 kB` `20.521 kB`	🆕 New entry
`library` Calendar Compat	`0 B` `0 B`	`153.428 kB` `40.128 kB`	🆕 New entry
`library` Card - All	`0 B` `0 B`	`103.994 kB` `29.353 kB`	🆕 New entry
`library` Card	`0 B` `0 B`	`97.005 kB` `27.612 kB`	🆕 New entry
`library` CardFooter	`0 B` `0 B`	`13.973 kB` `5.628 kB`	🆕 New entry
`library` CardHeader	`0 B` `0 B`	`16.216 kB` `6.39 kB`	🆕 New entry
`library` CardPreview	`0 B` `0 B`	`14.017 kB` `5.755 kB`	🆕 New entry
`library` Checkbox	`0 B` `0 B`	`35.658 kB` `12.072 kB`	🆕 New entry
`library` Combobox (including child components)	`0 B` `0 B`	`103.128 kB` `33.284 kB`	🆕 New entry
`library` CompoundButton	`0 B` `0 B`	`46.876 kB` `12.664 kB`	🆕 New entry
`library` CounterBadge	`0 B` `0 B`	`27.808 kB` `9.028 kB`	🆕 New entry
`library` DataGrid	`0 B` `0 B`	`168.498 kB` `46.733 kB`	🆕 New entry
`library` MessageBar (all components)	`0 B` `0 B`	`24.206 kB` `8.987 kB`	🆕 New entry
`library` Dialog (including children components)	`0 B` `0 B`	`100.478 kB` `30.072 kB`	🆕 New entry
`library` Divider	`0 B` `0 B`	`20.924 kB` `7.793 kB`	🆕 New entry
`library` Dropdown (including child components)	`0 B` `0 B`	`104.606 kB` `33.245 kB`	🆕 New entry
`library` Field	`0 B` `0 B`	`22.978 kB` `8.725 kB`	🆕 New entry
`library` FluentProvider	`0 B` `0 B`	`23.767 kB` `8.664 kB`	🆕 New entry
`library` hooks only	`0 B` `0 B`	`12.858 kB` `4.824 kB`	🆕 New entry
`library` Image	`0 B` `0 B`	`15.747 kB` `6.233 kB`	🆕 New entry
`library` @fluentui/react-breadcrumb - package	`0 B` `0 B`	`116.819 kB` `32.176 kB`	🆕 New entry
`library` Input	`0 B` `0 B`	`28.124 kB` `9.363 kB`	🆕 New entry
`library` InteractionTag	`0 B` `0 B`	`15.301 kB` `6.084 kB`	🆕 New entry
`library` Label	`0 B` `0 B`	`14.268 kB` `5.831 kB`	🆕 New entry
`library` Link	`0 B` `0 B`	`17.084 kB` `6.914 kB`	🆕 New entry
`library` Menu (including children components)	`0 B` `0 B`	`153.638 kB` `46.015 kB`	🆕 New entry
`library` Menu (including selectable components)	`0 B` `0 B`	`156.324 kB` `46.566 kB`	🆕 New entry
`library` MenuButton	`0 B` `0 B`	`44.294 kB` `12.545 kB`	🆕 New entry
`library` react-components: Accordion, Button, FluentProvider, Image, Menu, Popover	`0 B` `0 B`	`221.098 kB` `62.407 kB`	🆕 New entry
`library` Persona	`0 B` `0 B`	`57.068 kB` `17.823 kB`	🆕 New entry
`library` Popover	`0 B` `0 B`	`127.849 kB` `40.048 kB`	🆕 New entry
`library` Portal	`0 B` `0 B`	`13.717 kB` `4.886 kB`	🆕 New entry
`library` PresenceBadge	`0 B` `0 B`	`25.313 kB` `9.308 kB`	🆕 New entry
`library` Table (Primitives only)	`0 B` `0 B`	`45.326 kB` `14.119 kB`	🆕 New entry
`library` ProgressBar	`0 B` `0 B`	`17.43 kB` `6.903 kB`	🆕 New entry
`library` react-components: FluentProvider & webLightTheme	`0 B` `0 B`	`43.593 kB` `14.358 kB`	🆕 New entry
`library` Radio	`0 B` `0 B`	`32.952 kB` `10.254 kB`	🆕 New entry
`library` RadioGroup	`0 B` `0 B`	`15.356 kB` `6.268 kB`	🆕 New entry
`library` react-components: entire library	`0 B` `0 B`	`1.056 MB` `257.504 kB`	🆕 New entry
`library` Select	`0 B` `0 B`	`28.611 kB` `10.206 kB`	🆕 New entry
`library` Single theme token import	`0 B` `0 B`	`69 B` `89 B`	🆕 New entry
`library` Slider	`0 B` `0 B`	`39.951 kB` `12.971 kB`	🆕 New entry
`library` SpinButton	`0 B` `0 B`	`36.776 kB` `11.79 kB`	🆕 New entry
`library` Spinner	`0 B` `0 B`	`24.675 kB` `8.343 kB`	🆕 New entry
`library` SplitButton	`0 B` `0 B`	`52.308 kB` `14.137 kB`	🆕 New entry
`library` Switch	`0 B` `0 B`	`35.142 kB` `11.202 kB`	🆕 New entry
`library` Table as DataGrid	`0 B` `0 B`	`137.92 kB` `37.152 kB`	🆕 New entry
`library` Table (Selection only)	`0 B` `0 B`	`76.336 kB` `20.555 kB`	🆕 New entry
`library` Table (Sort only)	`0 B` `0 B`	`74.979 kB` `20.157 kB`	🆕 New entry
`library` Tag	`0 B` `0 B`	`29.094 kB` `9.42 kB`	🆕 New entry
`library` TagGroup	`0 B` `0 B`	`82.046 kB` `24.392 kB`	🆕 New entry
`library` Teams: all themes	`0 B` `0 B`	`35.666 kB` `7.453 kB`	🆕 New entry
`library` Teams: Light theme	`0 B` `0 B`	`19.642 kB` `5.549 kB`	🆕 New entry
`library` Text - Default	`0 B` `0 B`	`16.707 kB` `6.572 kB`	🆕 New entry
`library` Text - Wrappers	`0 B` `0 B`	`19.88 kB` `6.899 kB`	🆕 New entry
`library` Textarea	`0 B` `0 B`	`30.949 kB` `10.478 kB`	🆕 New entry
`library` Toast (including Toaster)	`0 B` `0 B`	`98.383 kB` `29.709 kB`	🆕 New entry
`library` ToggleButton	`0 B` `0 B`	`56.56 kB` `13.07 kB`	🆕 New entry
`library` Tooltip	`0 B` `0 B`	`54.666 kB` `19.208 kB`	🆕 New entry

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`global-context` createContext	`510 B` `328 B`
`global-context` createContextSelector	`537 B` `339 B`
`keyboard-key` keyboard-key package	`3.746 kB` `1.928 kB`
`priority-overflow` createOverflowManager	`4.447 kB` `1.853 kB`
`react` ActivityItem	`68.833 kB` `22.613 kB`
`react` Announced	`36.473 kB` `12.628 kB`
`react` Autofill	`15.365 kB` `4.743 kB`
`react` Breadcrumb	`196.131 kB` `58.76 kB`
`react` Button	`190.127 kB` `55.019 kB`
`react` ButtonGrid	`175.918 kB` `53.25 kB`
`react` Calendar	`118.756 kB` `36.101 kB`
`react` Callout	`80.866 kB` `26.564 kB`
`react` Check	`51.062 kB` `17.152 kB`
`react` Checkbox	`57.791 kB` `19.17 kB`
`react` ChoiceGroup	`63.339 kB` `20.824 kB`
`react` ChoiceGroupOption	`56.601 kB` `18.695 kB`
`react` Coachmark	`89.704 kB` `28.407 kB`
`react` Color	`7.737 kB` `3.106 kB`
`react` ColorPicker	`130.032 kB` `40.591 kB`
`react` ComboBox	`245.355 kB` `70.51 kB`
`react` CommandBar	`197.41 kB` `58.464 kB`
`react` ContextualMenu	`150.967 kB` `46.982 kB`
`react` DatePicker	`180.318 kB` `54.947 kB`
`react` DateTimeUtilities	`5.244 kB` `1.849 kB`
`react` DetailsList	`225.911 kB` `64.65 kB`
`react` Dialog	`205.294 kB` `61.428 kB`
`react` Divider	`17.63 kB` `6.234 kB`
`react` DocumentCard	`211.08 kB` `62.793 kB`
`react` DragDrop	`8.343 kB` `2.724 kB`
`react` DraggableZone	`33.345 kB` `11.166 kB`
`react` Dropdown	`227.809 kB` `66.884 kB`
`react` ExtendedPicker	`94.987 kB` `27.297 kB`
`react` Fabric	`39.75 kB` `13.688 kB`
`react` Facepile	`206.04 kB` `61.687 kB`
`react` FloatingPicker	`236.281 kB` `67.376 kB`
`react` FocusTrapZone	`15.831 kB` `5.54 kB`
`react` FocusZone	`53.259 kB` `16.869 kB`
`react` Grid	`175.918 kB` `53.25 kB`
`react` GroupedList	`131.707 kB` `39.689 kB`
`react` GroupedListV2	`119.324 kB` `36.822 kB`
`react` HoverCard	`93.735 kB` `29.778 kB`
`react` Icon	`49.74 kB` `16.603 kB`
`react` Icons	`65.829 kB` `24.212 kB`
`react` Image	`44.79 kB` `15.024 kB`
`react` Keytip	`78.588 kB` `25.825 kB`
`react` KeytipData	`13.585 kB` `4.418 kB`
`react` KeytipLayer	`100.422 kB` `31.128 kB`
`react` Keytips	`103.175 kB` `32.07 kB`
`react` Label	`36.347 kB` `12.639 kB`
`react` Layer	`45.683 kB` `15.585 kB`
`react` Link	`37.673 kB` `12.993 kB`
`react` List	`38.136 kB` `12.004 kB`
`react` MarqueeSelection	`72.119 kB` `21.676 kB`
`react` MessageBar	`184.707 kB` `55.523 kB`
`react` Modal	`90.409 kB` `29.213 kB`
`react` Nav	`183.442 kB` `55.093 kB`
`react` OverflowSet	`31.044 kB` `10.593 kB`
`react` Overlay	`38.784 kB` `13.401 kB`
`react` Panel	`194.946 kB` `58.34 kB`
`react` Persona	`111.753 kB` `35.58 kB`
`react` PersonaCoin	`111.753 kB` `35.58 kB`
`react` PersonaPresence	`55.928 kB` `18.715 kB`
`react` Pickers	`287.867 kB` `80.661 kB`
`react` Pivot	`184.252 kB` `55.823 kB`
`react` Popup	`12.032 kB` `4.114 kB`
`react` Positioning	`21.821 kB` `7.334 kB`
`react` PositioningContainer	`70.754 kB` `22.84 kB`
`react` ProgressIndicator	`37.498 kB` `12.906 kB`
`react` Rating	`78.989 kB` `25.18 kB`
`react` Fluent UI React (entire library)	`998.446 kB` `277.16 kB`
`react` ResizeGroup	`13.286 kB` `4.365 kB`
`react` ResponsiveMode	`8.078 kB` `2.95 kB`
`react` ScrollablePane	`53.538 kB` `17.113 kB`
`react` SearchBox	`182.982 kB` `55.1 kB`
`react` SelectableOption	`724 B` `413 B`
`react` SelectedItemsList	`226.707 kB` `66.319 kB`
`react` Selection	`41.202 kB` `11.839 kB`
`react` Separator	`33.397 kB` `11.529 kB`
`react` Shimmer	`47.265 kB` `15.632 kB`
`react` ShimmeredDetailsList	`236.679 kB` `67.422 kB`
`react` Slider	`55.575 kB` `18.574 kB`
`react` SpinButton	`186.661 kB` `56.205 kB`
`react` Spinner	`39.691 kB` `13.815 kB`
`react` Stack	`40.761 kB` `13.931 kB`
`react` Sticky	`32.064 kB` `10.324 kB`
`react` Styling	`44.812 kB` `14.688 kB`
`react` SwatchColorPicker	`186.166 kB` `56.724 kB`
`react` TeachingBubble	`200.004 kB` `59.345 kB`
`react` Text	`35.931 kB` `12.486 kB`
`react` TextField	`78.587 kB` `24.642 kB`
`react` Theme	`42.456 kB` `13.773 kB`
`react` ThemeGenerator	`12.34 kB` `4.106 kB`
`react` TimePicker	`235.197 kB` `68.29 kB`
`react` Toggle	`44.17 kB` `15.346 kB`
`react` Tooltip	`84.273 kB` `27.284 kB`
`react` Utilities	`71.851 kB` `21.843 kB`
`react` Viewport	`22.945 kB` `7.292 kB`
`react` WeeklyDayPicker	`98.762 kB` `30.828 kB`
`react` WindowProvider	`1.059 kB` `541 B`
`react-datepicker-compat` DatePicker Compat	`227.367 kB` `63.503 kB`
`react-infobutton` InfoButton	`139.602 kB` `43.628 kB`
`react-infobutton` InfoLabel	`143.417 kB` `44.844 kB`
`react-jsx-runtime` Classic Pragma	`1.057 kB` `530 B`
`react-jsx-runtime` JSX Dev Runtime	`3.781 kB` `1.646 kB`
`react-jsx-runtime` JSX Runtime	`4.377 kB` `1.881 kB`
`react-northstar` Accordion	`85.392 kB` `26.518 kB`
`react-northstar` Alert	`87.45 kB` `26.902 kB`
`react-northstar` Animation	`55.34 kB` `17.829 kB`
`react-northstar` Attachment	`86.844 kB` `26.692 kB`
`react-northstar` Avatar	`80.279 kB` `24.629 kB`
`react-northstar` Box	`75.248 kB` `23.806 kB`
`react-northstar` Breadcrumb	`79.92 kB` `24.709 kB`
`react-northstar` Button	`83.16 kB` `25.947 kB`
`react-northstar` Card	`82.705 kB` `25.023 kB`
`react-northstar` Carousel	`105.182 kB` `31.871 kB`
`react-northstar` Chat	`152.378 kB` `45.964 kB`
`react-northstar` Checkbox	`79.807 kB` `25.078 kB`
`react-northstar` Datepicker	`184.939 kB` `56.194 kB`
`react-northstar` Debug	`8.801 kB` `3.594 kB`
`react-northstar` Design	`36.589 kB` `12.067 kB`
`react-northstar` Dialog	`112.058 kB` `33.615 kB`
`react-northstar` Divider	`76.619 kB` `24.129 kB`
`react-northstar` Dropdown	`196.499 kB` `59.455 kB`
`react-northstar` Embed	`81.477 kB` `25.417 kB`
`react-northstar` Flex	`47.728 kB` `15.438 kB`
`react-northstar` Form	`92.527 kB` `28.879 kB`
`react-northstar` Grid	`70.584 kB` `22.278 kB`
`react-northstar` Header	`74.756 kB` `23.461 kB`
`react-northstar` Image	`73.591 kB` `23.329 kB`
`react-northstar` Input	`88.346 kB` `27.78 kB`
`react-northstar` ItemLayout	`78.231 kB` `24.454 kB`
`react-northstar` Label	`77.92 kB` `24.41 kB`
`react-northstar` Layout	`75.393 kB` `23.798 kB`
`react-northstar` List	`88.493 kB` `27.547 kB`
`react-northstar` Loader	`78.616 kB` `24.729 kB`
`react-northstar` Menu	`126.89 kB` `39.872 kB`
`react-northstar` MenuButton	`161.296 kB` `48.883 kB`
`react-northstar` Pill	`83.722 kB` `26.069 kB`
`react-northstar` Popup	`133.604 kB` `41.483 kB`
`react-northstar` Portal	`58.338 kB` `18.852 kB`
`react-northstar` Provider	`93.138 kB` `29.63 kB`
`react-northstar` RadioGroup	`83.282 kB` `26.053 kB`
`react-northstar` Reaction	`77.28 kB` `24.122 kB`
`react-northstar` Segment	`76.209 kB` `23.892 kB`
`react-northstar` Skeleton	`77.765 kB` `24.2 kB`
`react-northstar` Slider	`84.27 kB` `26.737 kB`
`react-northstar` SplitButton	`176.534 kB` `52.63 kB`
`react-northstar` Status	`76.272 kB` `24.05 kB`
`react-northstar` SvgIcon	`36.823 kB` `11.743 kB`
`react-northstar` Table	`80.796 kB` `25.154 kB`
`react-northstar` Text	`74.114 kB` `23.507 kB`
`react-northstar` TextArea	`74.248 kB` `23.492 kB`
`react-northstar` Toolbar	`173.345 kB` `52.08 kB`
`react-northstar` Tooltip	`108.261 kB` `34.482 kB`
`react-northstar` Tree	`87.855 kB` `27.217 kB`
`react-northstar` Video	`75.411 kB` `23.799 kB`
`react-portal-compat` PortalCompatProvider	`7.944 kB` `2.588 kB`
`react-positioning` usePositioning	`26.398 kB` `9.539 kB`
`react-swatch-picker-preview` @fluentui/react-swatch-picker-preview - package	`108.469 kB` `30.284 kB`
`react-tag-picker-preview` @fluentui/react-tag-picker-preview - package	`185.641 kB` `54.844 kB`
`react-timepicker-compat` TimePicker	`105.149 kB` `34.653 kB`
`react-utilities` SSRProvider	`180 B` `160 B`

_{🤖 This report was generated against 804e2233c02c78d04167609238c7c731f607e7e3}

fabricteam · 2024-04-16T15:32:22Z

Perf Analysis (`@fluentui/react-northstar`)

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
ChatDuplicateMessagesPerf.default	162	145	1.12:1
ChatWithPopoverPerf.default	201	179	1.12:1
AnimationMinimalPerf.default	312	287	1.09:1
ButtonSlotsPerf.default	331	303	1.09:1
FlexMinimalPerf.default	172	159	1.08:1
LayoutMinimalPerf.default	201	186	1.08:1
SkeletonMinimalPerf.default	207	195	1.06:1
AlertMinimalPerf.default	168	160	1.05:1
ButtonOverridesMissPerf.default	674	641	1.05:1
FormMinimalPerf.default	232	221	1.05:1
IconMinimalPerf.default	400	381	1.05:1
DialogMinimalPerf.default	451	434	1.04:1
DividerMinimalPerf.default	209	201	1.04:1
ListMinimalPerf.default	315	303	1.04:1
ListWith60ListItems.default	382	366	1.04:1
TableMinimalPerf.default	233	223	1.04:1
TextAreaMinimalPerf.default	301	289	1.04:1
TreeMinimalPerf.default	496	475	1.04:1
ChatMinimalPerf.default	456	443	1.03:1
GridMinimalPerf.default	191	186	1.03:1
HeaderSlotsPerf.default	488	476	1.03:1
LoaderMinimalPerf.default	189	184	1.03:1
ProviderMinimalPerf.default	207	200	1.03:1
SegmentMinimalPerf.default	201	196	1.03:1
ProviderMergeThemesPerf.default	659	648	1.02:1
AvatarMinimalPerf.default	112	111	1.01:1
CheckboxMinimalPerf.default	1132	1121	1.01:1
ImageMinimalPerf.default	225	222	1.01:1
RosterPerf.default	1561	1546	1.01:1
PopupMinimalPerf.default	350	346	1.01:1
TextMinimalPerf.default	192	190	1.01:1
AttachmentSlotsPerf.default	637	637	1:1
CarouselMinimalPerf.default	257	256	1:1
DatepickerMinimalPerf.default	3545	3544	1:1
DropdownMinimalPerf.default	1431	1431	1:1
MenuMinimalPerf.default	502	502	1:1
MenuButtonMinimalPerf.default	957	957	1:1
RadioGroupMinimalPerf.default	263	264	1:1
ReactionMinimalPerf.default	209	209	1:1
SliderMinimalPerf.default	741	744	1:1
SplitButtonMinimalPerf.default	2231	2225	1:1
VideoMinimalPerf.default	441	443	1:1
CardMinimalPerf.default	310	314	0.99:1
DropdownManyItemsPerf.default	390	395	0.99:1
InputMinimalPerf.default	557	561	0.99:1
TableManyItemsPerf.default	1094	1107	0.99:1
CustomToolbarPrototype.default	1485	1495	0.99:1
AccordionMinimalPerf.default	90	92	0.98:1
EmbedMinimalPerf.default	1860	1902	0.98:1
HeaderMinimalPerf.default	203	208	0.98:1
ItemLayoutMinimalPerf.default	694	709	0.98:1
ListCommonPerf.default	392	400	0.98:1
ListNestedPerf.default	314	320	0.98:1
ButtonMinimalPerf.default	92	95	0.97:1
LabelMinimalPerf.default	226	233	0.97:1
StatusMinimalPerf.default	384	395	0.97:1
ToolbarMinimalPerf.default	532	548	0.97:1
TooltipMinimalPerf.default	1242	1282	0.97:1
RefMinimalPerf.default	110	114	0.96:1
AttachmentMinimalPerf.default	76	80	0.95:1
BoxMinimalPerf.default	196	209	0.94:1
PortalMinimalPerf.default	79	84	0.94:1
TreeWith60ListItems.default	85	90	0.94:1

fabricteam · 2024-04-16T15:39:47Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
BaseButton	mount	654	620	5000
Breadcrumb	mount	1688	1705	1000
Checkbox	mount	1708	1700	5000
CheckboxBase	mount	1459	1462	5000
ChoiceGroup	mount	2938	2920	5000
ComboBox	mount	673	660	1000
CommandBar	mount	6268	6283	1000
ContextualMenu	mount	12787	12609	1000
DefaultButton	mount	767	768	5000
DetailsRow	mount	2185	2163	5000
DetailsRowFast	mount	2169	2157	5000
DetailsRowNoStyles	mount	2027	2008	5000
Dialog	mount	2829	2681	1000
DocumentCardTitle	mount	229	217	1000
Dropdown	mount	1958	2009	5000
FocusTrapZone	mount	1166	1145	5000
FocusZone	mount	1097	1087	5000
GroupedList	mount	37689	41876	2
GroupedList	virtual-rerender	18035	20146	2
GroupedList	virtual-rerender-with-unmount	51175	50866	2
GroupedListV2	mount	225	222	2
GroupedListV2	virtual-rerender	220	217	2
GroupedListV2	virtual-rerender-with-unmount	227	235	2
IconButton	mount	1093	1111	5000
Label	mount	331	337	5000
Layer	mount	2750	2714	5000
Link	mount	396	396	5000
MenuButton	mount	940	943	5000
MessageBar	mount	21433	21473	5000
Nav	mount	1921	1949	1000
OverflowSet	mount	796	781	5000
Panel	mount	1756	1765	1000
Persona	mount	742	744	1000
Pivot	mount	881	877	1000
PrimaryButton	mount	840	833	5000
Rating	mount	4607	4626	5000
SearchBox	mount	915	930	5000
Shimmer	mount	1854	1828	5000
Slider	mount	1339	1345	5000
SpinButton	mount	3002	2847	5000
Spinner	mount	391	381	5000
SplitButton	mount	1846	1831	5000
Stack	mount	417	399	5000
StackWithIntrinsicChildren	mount	862	845	5000
StackWithTextChildren	mount	2611	2616	5000
SwatchColorPicker	mount	6196	6262	5000
TagPicker	mount	1410	1426	5000
Text	mount	363	367	5000
TextField	mount	945	919	5000
ThemeProvider	mount	826	828	5000
ThemeProvider	virtual-rerender	584	579	5000
ThemeProvider	virtual-rerender-with-unmount	1267	1253	5000
Toggle	mount	599	623	5000
buttonNative	mount	188	187	5000

fabricteam · 2024-04-16T15:47:39Z

🕵 FluentUIV0 No visual regressions between this PR and main

fabricteam · 2024-04-16T15:52:23Z

🕵 fluentuiv9 No visual regressions between this PR and main

… split into /library and /stories within getPackageStoriesGlob()

…s within /stories project

…oject

…ctor if present and run yanr install after generator finished

…react-*/lib|stories

…ake isUsingPathAliasesForDx lazy => improve d.ts generation by ~60%

…split-in-two --all flag

… test setup

…inal and use it as main type-check just script

…perf boost

…ode with --incremental arg

…-check work

…e not allowed with new fast type-check

…y builds - similar to lage

fabricteam · 2024-04-19T12:26:39Z

@@ -0,0 +1,38 @@
+steps:


🕵 fluentuiv8 Open the Visual Regressions report to inspect the affected screenshots

Pivot - Overflow 2 screenshots

Image Name Diff(in Pixels) Image Type

Pivot - Overflow.Tabs - RTL.Narrow - Last tab selected.chromium.png 0 Added

Pivot - Overflow.Tabs - RTL.Narrow - Overflow menu.chromium.png 0 Added

layershifter · 2024-08-13T13:50:06Z

Closing for housekeeping 🏡 Feel free to re-open

Hotell added the Status: Do Not Merge 🚫 label Apr 16, 2024

github-actions Bot added this to the April Project Cycle Q1 2024 milestone Apr 16, 2024

Hotell force-pushed the type-checking-perf/bench/after branch from 46f0cdc to 8f5571b Compare April 16, 2024 15:28

Hotell force-pushed the type-checking-perf/bench/after branch 10 times, most recently from 922f853 to f97cdfc Compare April 18, 2024 16:21

Hotell mentioned this pull request Apr 18, 2024

Feature(monosize): make packageName configurale within compare-reports command microsoft/monosize#62

Closed

Hotell added 9 commits April 19, 2024 12:59

feat(workspace-library): initial split-library-in-two implementation

bd5c91d

feat(scrtips-storybook): resolve stories properly if project has been…

c1bf46b

… split into /library and /stories within getPackageStoriesGlob()

feat(workspace-plugin): add --all flag support to split-library-in-two

3463468

feat(workspace-plugin): setup correctly eslint extraneous dependencie…

aca1358

…s within /stories project

feat(workspace-plugin): dont add test-ssr target to /stories project

83a4049

fix(workspace-plugin): exit flow when assetProject catches invalid pr…

cc692b0

…oject

fix(workspace-plugin): update test-ssr target only if present

db30c3e

feat(workspace-plugin): update paths in tsconfigLib,babelrc,api-extra…

76afa18

…ctor if present and run yanr install after generator finished

chore: add new workspace path resolution for nested react-components/…

63ecd55

…react-*/lib|stories

Hotell added 26 commits April 19, 2024 12:59

ci: update pipeline for measurements

8ea341d

remove: revert to remove conflicts

8f814c9

remove: fix tsc errors within scripts-tasks

a5c6347

ci: update pipeline for measurements V2

c475597

ci: update pipeline for measurements V3

14ad287

perf(scripts-task): turn off path aliases within generate-api task, m…

7c3b27e

…ake isUsingPathAliasesForDx lazy => improve d.ts generation by ~60%

fix(react-components/*): remove circular dependencies from cypress files

b3f098c

feat(workspace-plugin): improve performance and terminal outputs for …

5d6cb17

…split-in-two --all flag

feat: split v9 packages in two

2815c55

undo adding unstable folder to git

1e4dffa

fix(react-provider): fix babel config after split

3b9ee7a

fix: split v9 packages in two - AFTERFIX

6f27159

fix: re-generate api.md files after split

96b979b

fix(react-components-stories): split v9 packages in two - add missing…

b3c7a5a

… test setup

fix: split v9 packages in two - AFTERFIX

79e50ba

fix(react-virtualizer-stories): split v9 packages in two - AFTERFIX

4411583

feat(scripts-tasks): implement type-checkV2 which is faster than orig…

2982859

…inal and use it as main type-check just script

ci(remove): run nx first to avoid isssues for data metrics

37b0d30

split pipelines for better data measurements

53edf47

feat: update type-check commands to v9 non web libraries to get same …

97b3d93

…perf boost

chore(web-components): encapsulate build command in order to not expl…

1560f0a

…ode with --incremental arg

ci(scripts-tasks): use node env variable to reliable run --incremental

1dae450

feat: split in two calendar-compat & motion-preview to make fast type…

592e6ff

…-check work

feat: resolve SELF dependencies in global-context/infobutton which ar…

98d1fbc

…e not allowed with new fast type-check

update api files after rebase

206dc24

fix(nx): make type-check target depend on self build and all dependen…

bdf3b75

…y builds - similar to lage

Hotell force-pushed the type-checking-perf/bench/after branch from 8156e75 to bdf3b75 Compare April 19, 2024 12:10

fabricteam reviewed Apr 19, 2024

View reviewed changes

layershifter closed this Aug 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Type checking perf/bench/after#31066

Type checking perf/bench/after#31066
Hotell wants to merge 40 commits into
microsoft:masterfrom
Hotell:type-checking-perf/bench/after

Hotell commented Apr 16, 2024 •

edited

Loading

Uh oh!

codesandbox-ci Bot commented Apr 16, 2024 •

edited

Loading

Uh oh!

fabricteam commented Apr 16, 2024 •

edited

Loading

Uh oh!

fabricteam commented Apr 16, 2024 •

edited

Loading

Uh oh!

fabricteam commented Apr 16, 2024 •

edited

Loading

Uh oh!

fabricteam commented Apr 16, 2024 •

edited

Loading

Uh oh!

fabricteam commented Apr 16, 2024 •

edited

Loading

Uh oh!

fabricteam commented Apr 16, 2024 •

edited

Loading

Uh oh!

fabricteam Apr 19, 2024

Uh oh!

layershifter commented Aug 13, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Image Name	Diff(in Pixels)	Image Type
Pivot - Overflow.Tabs - RTL.Narrow - Last tab selected.chromium.png	0	Added
Pivot - Overflow.Tabs - RTL.Narrow - Overflow menu.chromium.png	0	Added

Uh oh!

Conversation

Hotell commented Apr 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Previous Behavior

New Behavior

Related Issue(s)

Uh oh!

codesandbox-ci Bot commented Apr 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fabricteam commented Apr 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react-components)

Uh oh!

fabricteam commented Apr 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Bundle size report

Uh oh!

fabricteam commented Apr 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react-northstar)

Uh oh!

fabricteam commented Apr 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react)

Uh oh!

fabricteam commented Apr 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🕵 FluentUIV0 No visual regressions between this PR and main

Uh oh!

fabricteam commented Apr 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🕵 fluentuiv9 No visual regressions between this PR and main

Uh oh!

fabricteam Apr 19, 2024

Choose a reason for hiding this comment

🕵 fluentuiv8 Open the Visual Regressions report to inspect the affected screenshots

Uh oh!

layershifter commented Aug 13, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Hotell commented Apr 16, 2024 •

edited

Loading

codesandbox-ci Bot commented Apr 16, 2024 •

edited

Loading

fabricteam commented Apr 16, 2024 •

edited

Loading

Perf Analysis (`@fluentui/react-components`)

fabricteam commented Apr 16, 2024 •

edited

Loading

fabricteam commented Apr 16, 2024 •

edited

Loading

Perf Analysis (`@fluentui/react-northstar`)

fabricteam commented Apr 16, 2024 •

edited

Loading

Perf Analysis (`@fluentui/react`)

fabricteam commented Apr 16, 2024 •

edited

Loading

fabricteam commented Apr 16, 2024 •

edited

Loading