TeachingPopover: Automated Tests#30836
Merged
Mitch-At-Work merged 3 commits intoMar 25, 2024
Merged
Conversation
Collaborator
📊 Bundle size report🤖 This report was generated against 0a593445b3809289313bc6d49dedd18f33a850e4 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Contributor
|
I guess you did this because it's part of our Convergence epic "steps" ? This "perf" approach is outdated and provides no value for us as it uses flamegril which doesn't work in browsers that we support. I'd suggest to close this and not merge or just remove those "perf test" and land bundle-size setup |
Contributor
Author
|
Updated to only enable bundle size |
brandonthomas
approved these changes
Mar 25, 2024
robertpenner
pushed a commit
to robertpenner/fluentui
that referenced
this pull request
Apr 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the automated checks for both bundle size and performance to TeachingPopover