Fix order of default ownership of docs folder.#30678
Closed
AtishayMsft wants to merge 1 commit into
Closed
Conversation
Collaborator
📊 Bundle size report🤖 This report was generated against cb7b32981d6f82f0696a8e89e3ea19dd2eee3266 |
AtishayMsft
requested review from
a team,
JustSlone,
jurokapsiar and
tudorpopams
as code owners
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Contributor
Author
|
This issue is resolved now. Closing the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Ownership of docs folder was added recently in this PR #30483
As the scope was added at the bottom of the file, it caused the ownership of all sub directories that contain docs folder to get overridden.
New Behavior
Moving the docs folder ownership to the top of CODEOWNERS file.
So that any existing sub directory ownership scopes do not break.
Related Issue(s)