feat(react-motion): add support to provide duration to useMotion hook#29655
Merged
marcosmoura merged 11 commits intoOct 26, 2023
Merged
Conversation
* master: feat(scripts-task): implement initial verify-packaging task (microsoft#29595)
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 657 | 616 | 5000 | |
| Button | mount | 317 | 328 | 5000 | |
| Field | mount | 1094 | 1134 | 5000 | |
| FluentProvider | mount | 701 | 731 | 5000 | |
| FluentProviderWithTheme | mount | 77 | 89 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 61 | 58 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 73 | 74 | 10 | |
| MakeStyles | mount | 846 | 851 | 50000 | |
| Persona | mount | 1745 | 1751 | 5000 | |
| SpinButton | mount | 1387 | 1343 | 5000 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 508f31d:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 01912382b9a202b132f32a78fe8c67db5348b281 (build) |
Hotell
approved these changes
Oct 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new option to
useMotionhook: durationA Storybook documentation will be added in a follow-up PR.
Description
The idea is to have a hook that returns Motion with a predefined hardcoded duration, avoiding the need to compute the styles to infer the duration.
With the addition of this option, we enable the following:
Usage