Skip to content

feat(react-datepicker-compat): Update DatePicker to use react-calendar-compat#29587

Merged
sopranopillow merged 7 commits into
microsoft:masterfrom
sopranopillow:datepicker-compat/use-calendar-compat
Oct 19, 2023
Merged

feat(react-datepicker-compat): Update DatePicker to use react-calendar-compat#29587
sopranopillow merged 7 commits into
microsoft:masterfrom
sopranopillow:datepicker-compat/use-calendar-compat

Conversation

@sopranopillow

@sopranopillow sopranopillow commented Oct 18, 2023

Copy link
Copy Markdown
Contributor

Previous Behavior

DatePicker used an internal calendar that wasn't exposed.

New Behavior

Now that Calendar lives under react-calendar-compat, per #29438, we can now remove the internal calendar and just import react-calendar-compat. This PR adds this change.

Related Issue(s)

@sopranopillow sopranopillow self-assigned this Oct 18, 2023
@sopranopillow sopranopillow requested review from a team and khmakoto as code owners October 18, 2023 20:36
@codesandbox-ci

codesandbox-ci Bot commented Oct 18, 2023

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4938d21:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam

fabricteam commented Oct 18, 2023

Copy link
Copy Markdown
Collaborator

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-datepicker-compat
DatePicker Compat
212.464 kB
59.301 kB
212.458 kB
59.316 kB
-6 B
15 B

🤖 This report was generated against 4ac68a632b61c2cb1886f32a6293c3218bf07c0e

@size-auditor

size-auditor Bot commented Oct 18, 2023

Copy link
Copy Markdown

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 4ac68a632b61c2cb1886f32a6293c3218bf07c0e (build)

@sopranopillow sopranopillow requested a review from a team as a code owner October 18, 2023 21:04
@fabricteam

fabricteam commented Oct 18, 2023

Copy link
Copy Markdown
Collaborator

🕵 fluentuiv9 No visual regressions between this PR and main

Comment thread packages/react-components/react-datepicker-compat/src/index.ts
@sopranopillow sopranopillow merged commit 6267758 into microsoft:master Oct 19, 2023
@sopranopillow sopranopillow deleted the datepicker-compat/use-calendar-compat branch October 19, 2023 19:38
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Oct 24, 2023
* master: (48 commits)
  fix(react-drawer): regression with mountNode prop not available after refactoring (microsoft#29524)
  feat(react-storybook-addon-codesandbox): support various providers for "export to" functionality (microsoft#29536)
  feat(TimePicker-compat): call onTimeSelect on blur (microsoft#29597)
  feat: (breadcrumb) Removed appearance prop (microsoft#29554)
  chore(deps): bump fsevents from 1.2.9 to 1.2.13 (microsoft#29476)
  Adding comment in Hovercard that we support cumulative area chart currently (microsoft#29395)
  applying package updates
  applying package updates
  chore(vr-tests-react-components, perf-tests-app): Remove infobutton from vr-tests and perf test app (microsoft#29603)
  docs: Add guidance for modifying textarea's height. (microsoft#29601)
  fix(react-calendar-compat): Classnames removed and added to day cells need to be split instead of providing a string with spaces (microsoft#29611)
  [Part 2] Changes to onboard charting to fluent docsite (microsoft#29608)
  chore: bump jest to 29.7.0 (microsoft#29298)
  applying package updates
  feat(react-infolabel, react-components): Release InfoLabel to stable (microsoft#29585)
  feat(react-datepicker-compat): Update DatePicker to use react-calendar-compat (microsoft#29587)
  feat: adds motion to DialogSurface (microsoft#29391)
  fix: Use correct target windows for ResizeObserver (microsoft#29551)
  chg (microsoft#29592)
  Fix missing x callout custom callout (microsoft#29547)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update DatePicker Compat to consume Calendar Compat [@fluentui/react-calendar-compat]: Extract Calendar from DatePicker compat into its own package

4 participants