Skip to content

feat: Release MessageBar as stable#29502

Merged
ling1726 merged 3 commits into
microsoft:masterfrom
ling1726:react-message-bar/feat/release
Oct 12, 2023
Merged

feat: Release MessageBar as stable#29502
ling1726 merged 3 commits into
microsoft:masterfrom
ling1726:react-message-bar/feat/release

Conversation

@ling1726

@ling1726 ling1726 commented Oct 11, 2023

Copy link
Copy Markdown
Contributor

@ling1726 ling1726 force-pushed the react-message-bar/feat/release branch from 7aa0445 to 16e09eb Compare October 11, 2023 19:10
@fabricteam

fabricteam commented Oct 11, 2023

Copy link
Copy Markdown
Collaborator

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
InfoButton mount 11 15 5000 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 655 630 5000
Button mount 317 327 5000
Field mount 1108 1129 5000
FluentProvider mount 699 699 5000
FluentProviderWithTheme mount 79 79 10
FluentProviderWithTheme virtual-rerender 63 60 10
FluentProviderWithTheme virtual-rerender-with-unmount 72 81 10
InfoButton mount 11 15 5000 Possible regression
MakeStyles mount 856 838 50000
Persona mount 1756 1674 5000
SpinButton mount 1365 1367 5000

@codesandbox-ci

codesandbox-ci Bot commented Oct 11, 2023

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d639e65:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam

fabricteam commented Oct 11, 2023

Copy link
Copy Markdown
Collaborator

Perf Analysis (@fluentui/react-northstar)

⚠️ 1 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
ButtonMinimalPerf.default 96 84 1.14:1 analysis
Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
RefMinimalPerf.default 118 109 1.08:1
TextMinimalPerf.default 199 185 1.08:1
ButtonOverridesMissPerf.default 663 617 1.07:1
LayoutMinimalPerf.default 208 195 1.07:1
ListNestedPerf.default 330 307 1.07:1
FlexMinimalPerf.default 164 154 1.06:1
CardMinimalPerf.default 316 301 1.05:1
FormMinimalPerf.default 228 218 1.05:1
LoaderMinimalPerf.default 197 188 1.05:1
SplitButtonMinimalPerf.default 2333 2245 1.04:1
AnimationMinimalPerf.default 304 294 1.03:1
CarouselMinimalPerf.default 257 250 1.03:1
ChatWithPopoverPerf.default 189 183 1.03:1
HeaderSlotsPerf.default 464 450 1.03:1
RosterPerf.default 1614 1567 1.03:1
ReactionMinimalPerf.default 213 207 1.03:1
BoxMinimalPerf.default 195 192 1.02:1
ChatMinimalPerf.default 430 423 1.02:1
DropdownManyItemsPerf.default 387 378 1.02:1
HeaderMinimalPerf.default 208 204 1.02:1
PopupMinimalPerf.default 358 352 1.02:1
SkeletonMinimalPerf.default 198 194 1.02:1
CustomToolbarPrototype.default 1481 1452 1.02:1
TooltipMinimalPerf.default 1275 1244 1.02:1
TreeWith60ListItems.default 93 91 1.02:1
CheckboxMinimalPerf.default 1154 1139 1.01:1
DialogMinimalPerf.default 448 444 1.01:1
DropdownMinimalPerf.default 1431 1412 1.01:1
GridMinimalPerf.default 187 186 1.01:1
ItemLayoutMinimalPerf.default 710 700 1.01:1
ListMinimalPerf.default 309 306 1.01:1
MenuMinimalPerf.default 504 498 1.01:1
ProviderMinimalPerf.default 208 206 1.01:1
RadioGroupMinimalPerf.default 269 266 1.01:1
TreeMinimalPerf.default 483 476 1.01:1
DatepickerMinimalPerf.default 3678 3665 1:1
DividerMinimalPerf.default 196 196 1:1
ImageMinimalPerf.default 221 220 1:1
MenuButtonMinimalPerf.default 942 944 1:1
ToolbarMinimalPerf.default 527 529 1:1
ButtonSlotsPerf.default 316 319 0.99:1
EmbedMinimalPerf.default 1868 1894 0.99:1
InputMinimalPerf.default 541 545 0.99:1
ListWith60ListItems.default 365 367 0.99:1
ProviderMergeThemesPerf.default 642 648 0.99:1
SliderMinimalPerf.default 720 727 0.99:1
TextAreaMinimalPerf.default 289 292 0.99:1
AccordionMinimalPerf.default 82 84 0.98:1
TableManyItemsPerf.default 1097 1120 0.98:1
TableMinimalPerf.default 229 233 0.98:1
AttachmentSlotsPerf.default 627 644 0.97:1
AvatarMinimalPerf.default 103 106 0.97:1
ChatDuplicateMessagesPerf.default 154 159 0.97:1
ListCommonPerf.default 371 384 0.97:1
SegmentMinimalPerf.default 189 195 0.97:1
IconMinimalPerf.default 383 395 0.97:1
VideoMinimalPerf.default 420 431 0.97:1
LabelMinimalPerf.default 210 218 0.96:1
StatusMinimalPerf.default 381 396 0.96:1
AlertMinimalPerf.default 153 161 0.95:1
AttachmentMinimalPerf.default 78 83 0.94:1
PortalMinimalPerf.default 85 105 0.81:1

@fabricteam

fabricteam commented Oct 11, 2023

Copy link
Copy Markdown
Collaborator

🕵 fluentuiv8 No visual regressions between this PR and main

@fabricteam

fabricteam commented Oct 11, 2023

Copy link
Copy Markdown
Collaborator

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam

fabricteam commented Oct 11, 2023

Copy link
Copy Markdown
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext
510 B
330 B
global-context
createContextSelector
537 B
342 B
priority-overflow
createOverflowManager
4.162 kB
1.735 kB
react-accordion
Accordion (including children components)
92.961 kB
28.372 kB
react-alert
Alert
85.296 kB
23.629 kB
react-avatar
Avatar
50.461 kB
15.901 kB
react-avatar
AvatarGroup
19.992 kB
7.871 kB
react-avatar
AvatarGroupItem
65.117 kB
20.238 kB
react-badge
Badge
27.197 kB
8.779 kB
react-badge
CounterBadge
28.098 kB
9.074 kB
react-badge
PresenceBadge
25.603 kB
9.283 kB
react-button
Button
41.016 kB
11.416 kB
react-button
CompoundButton
48.372 kB
12.897 kB
react-button
MenuButton
45.79 kB
12.79 kB
react-button
SplitButton
53.804 kB
14.382 kB
react-button
ToggleButton
58.063 kB
13.315 kB
react-card
Card - All
92.829 kB
26.915 kB
react-card
Card
87.653 kB
25.399 kB
react-card
CardFooter
13.423 kB
5.481 kB
react-card
CardHeader
15.666 kB
6.235 kB
react-card
CardPreview
14.374 kB
5.854 kB
react-checkbox
Checkbox
37.235 kB
12.278 kB
react-combobox
Combobox (including child components)
91.564 kB
29.879 kB
react-combobox
Dropdown (including child components)
90.004 kB
29.537 kB
react-components
react-components: Button, FluentProvider & webLightTheme
70.872 kB
20.3 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
208.629 kB
59.868 kB
react-components
react-components: FluentProvider & webLightTheme
42.142 kB
13.97 kB
react-datepicker-compat
DatePicker Compat
211.96 kB
59.117 kB
react-dialog
Dialog (including children components)
89.578 kB
26.737 kB
react-divider
Divider
21.112 kB
7.812 kB
react-field
Field
22.721 kB
8.611 kB
react-image
Image
16.096 kB
6.317 kB
react-infobutton
InfoButton
130.378 kB
41.093 kB
react-infobutton
InfoLabel
134.068 kB
42.26 kB
react-input
Input
27.247 kB
9.194 kB
react-jsx-runtime
Classic Pragma
1.049 kB
531 B
react-jsx-runtime
JSX Dev Runtime
4.14 kB
1.741 kB
react-jsx-runtime
JSX Runtime
4.734 kB
1.983 kB
react-label
Label
14.435 kB
5.83 kB
react-link
Link
17.328 kB
6.947 kB
react-menu
Menu (including children components)
140.201 kB
43.339 kB
react-menu
Menu (including selectable components)
142.887 kB
43.852 kB
react-overflow
hooks only
12.419 kB
4.687 kB
react-persona
Persona
57.352 kB
17.774 kB
react-popover
Popover
119.11 kB
37.616 kB
react-portal
Portal
12.255 kB
4.504 kB
react-portal-compat
PortalCompatProvider
6.503 kB
2.22 kB
react-positioning
usePositioning
25.305 kB
9.162 kB
react-progress
ProgressBar
17.725 kB
6.965 kB
react-provider
FluentProvider
22.687 kB
8.399 kB
react-radio
Radio
30.996 kB
10.223 kB
react-radio
RadioGroup
15.631 kB
6.33 kB
react-select
Select
28.968 kB
10.269 kB
react-slider
Slider
38.146 kB
12.57 kB
react-spinbutton
SpinButton
37.133 kB
11.856 kB
react-spinner
Spinner
23.688 kB
8.536 kB
react-switch
Switch
33.455 kB
10.846 kB
react-table
DataGrid
156.97 kB
43.826 kB
react-table
Table (Primitives only)
43.797 kB
13.732 kB
react-table
Table as DataGrid
130.265 kB
35.168 kB
react-table
Table (Selection only)
75.633 kB
20.448 kB
react-table
Table (Sort only)
74.24 kB
20.048 kB
react-tags
InteractionTag
15.618 kB
6.152 kB
react-tags
Tag
30.341 kB
9.505 kB
react-tags
TagGroup
73.857 kB
22.067 kB
react-text
Text - Default
17.065 kB
6.645 kB
react-text
Text - Wrappers
20.237 kB
6.965 kB
react-textarea
Textarea
31.306 kB
10.549 kB
react-theme
Single theme token import
69 B
89 B
react-theme
Teams: all themes
34.611 kB
7.295 kB
react-theme
Teams: Light theme
19.282 kB
5.486 kB
react-toast
Toast (including Toaster)
92.478 kB
27.738 kB
react-tooltip
Tooltip
52.322 kB
18.42 kB
react-utilities
SSRProvider
180 B
159 B
🤖 This report was generated against c2e09fe47acb6010fdb188026180ee505abb9f67

@size-auditor

size-auditor Bot commented Oct 11, 2023

Copy link
Copy Markdown

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: c2e09fe47acb6010fdb188026180ee505abb9f67 (build)

@fabricteam

fabricteam commented Oct 11, 2023

Copy link
Copy Markdown
Collaborator

🕵 fluentuiv9 No visual regressions between this PR and main

@fabricteam

fabricteam commented Oct 11, 2023

Copy link
Copy Markdown
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 631 637 5000
Breadcrumb mount 1672 1661 1000
Checkbox mount 1676 1672 5000
CheckboxBase mount 1456 1484 5000
ChoiceGroup mount 2880 2873 5000
ComboBox mount 643 668 1000
CommandBar mount 6118 6159 1000
ContextualMenu mount 12573 12890 1000
DefaultButton mount 748 742 5000
DetailsRow mount 2152 2159 5000
DetailsRowFast mount 2164 2214 5000
DetailsRowNoStyles mount 1996 1983 5000
Dialog mount 2679 2729 1000
DocumentCardTitle mount 239 227 1000
Dropdown mount 1979 1995 5000
FocusTrapZone mount 1115 1152 5000
FocusZone mount 1091 1069 5000
GroupedList mount 36911 40860 2
GroupedList virtual-rerender 19718 19835 2
GroupedList virtual-rerender-with-unmount 50084 50500 2
GroupedListV2 mount 230 235 2
GroupedListV2 virtual-rerender 216 213 2
GroupedListV2 virtual-rerender-with-unmount 225 234 2
IconButton mount 1068 1076 5000
Label mount 330 338 5000
Layer mount 2825 2678 5000
Link mount 388 396 5000
MenuButton mount 962 931 5000
MessageBar mount 21391 21406 5000
Nav mount 1948 1937 1000
OverflowSet mount 772 795 5000
Panel mount 1761 1758 1000
Persona mount 736 757 1000
Pivot mount 850 874 1000
PrimaryButton mount 847 861 5000
Rating mount 4550 4561 5000
SearchBox mount 912 887 5000
Shimmer mount 1876 1818 5000
Slider mount 1295 1344 5000
SpinButton mount 2841 2836 5000
Spinner mount 399 392 5000
SplitButton mount 1814 1862 5000
Stack mount 422 414 5000
StackWithIntrinsicChildren mount 834 846 5000
StackWithTextChildren mount 2580 2602 5000
SwatchColorPicker mount 6057 6028 5000
TagPicker mount 1456 1457 5000
Text mount 375 371 5000
TextField mount 939 926 5000
ThemeProvider mount 830 841 5000
ThemeProvider virtual-rerender 595 586 5000
ThemeProvider virtual-rerender-with-unmount 1255 1289 5000
Toggle mount 615 631 5000
buttonNative mount 200 204 5000

@ling1726 ling1726 marked this pull request as ready for review October 12, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants