Skip to content

Adding comment in Hovercard that we support cumulative area chart currently#29395

Merged
ankityadav4 merged 7 commits into
microsoft:masterfrom
ankityadav4:areachart-8599
Oct 23, 2023
Merged

Adding comment in Hovercard that we support cumulative area chart currently#29395
ankityadav4 merged 7 commits into
microsoft:masterfrom
ankityadav4:areachart-8599

Conversation

@ankityadav4

Copy link
Copy Markdown
Contributor

…rently

Previous Behavior

New Behavior

Related Issue(s)

  • Fixes #

@fabricteam

fabricteam commented Oct 4, 2023

Copy link
Copy Markdown
Collaborator

📊 Bundle size report

🤖 This report was generated against 4c36df0e2a7bf9d54d5137fabe74c720bdddebbc

@codesandbox-ci

codesandbox-ci Bot commented Oct 4, 2023

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2cf4700:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor

size-auditor Bot commented Oct 4, 2023

Copy link
Copy Markdown

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 4c36df0e2a7bf9d54d5137fabe74c720bdddebbc (build)

Comment thread packages/react-charting/src/components/AreaChart/AreaChart.base.tsx Outdated
@fabricteam

fabricteam commented Oct 12, 2023

Copy link
Copy Markdown
Collaborator

🕵 fluentuiv8 No visual regressions between this PR and main

Comment thread packages/react-charting/src/components/CommonComponents/CartesianChart.types.ts Outdated
@ankityadav4 ankityadav4 force-pushed the areachart-8599 branch 2 times, most recently from 1a2c816 to 4585516 Compare October 17, 2023 04:17
Comment thread change/@fluentui-react-charting-acfa7b51-4c62-47b3-b7fd-09a97c5e9d67.json Outdated
@ankityadav4 ankityadav4 marked this pull request as ready for review October 23, 2023 17:04
@ankityadav4 ankityadav4 requested a review from a team as a code owner October 23, 2023 17:04
@ankityadav4 ankityadav4 merged commit 742d551 into microsoft:master Oct 23, 2023
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Oct 24, 2023
* master: (48 commits)
  fix(react-drawer): regression with mountNode prop not available after refactoring (microsoft#29524)
  feat(react-storybook-addon-codesandbox): support various providers for "export to" functionality (microsoft#29536)
  feat(TimePicker-compat): call onTimeSelect on blur (microsoft#29597)
  feat: (breadcrumb) Removed appearance prop (microsoft#29554)
  chore(deps): bump fsevents from 1.2.9 to 1.2.13 (microsoft#29476)
  Adding comment in Hovercard that we support cumulative area chart currently (microsoft#29395)
  applying package updates
  applying package updates
  chore(vr-tests-react-components, perf-tests-app): Remove infobutton from vr-tests and perf test app (microsoft#29603)
  docs: Add guidance for modifying textarea's height. (microsoft#29601)
  fix(react-calendar-compat): Classnames removed and added to day cells need to be split instead of providing a string with spaces (microsoft#29611)
  [Part 2] Changes to onboard charting to fluent docsite (microsoft#29608)
  chore: bump jest to 29.7.0 (microsoft#29298)
  applying package updates
  feat(react-infolabel, react-components): Release InfoLabel to stable (microsoft#29585)
  feat(react-datepicker-compat): Update DatePicker to use react-calendar-compat (microsoft#29587)
  feat: adds motion to DialogSurface (microsoft#29391)
  fix: Use correct target windows for ResizeObserver (microsoft#29551)
  chg (microsoft#29592)
  Fix missing x callout custom callout (microsoft#29547)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants