Minimum height feature for bar chart by Shubhabrata08 · Pull Request #29359 · microsoft/fluentui

Shubhabrata08 · 2023-10-02T15:21:47Z

New Behavior

Related Issue(s)

Fixes [Feature]: Add barMinimumHeight property to VerticalBarChart #29282

Can this be a viable way to implement this? As changing props can be a contract change for the component and might be a breaking change?
Basically setting the minimum scaled height for all non-zero values to 1.
If this is a viable way, I can proceed with updating the tests.
PS: I have quite less experience in this...

…inimum-height-feature-bar-chart

codesandbox-ci · 2023-10-02T15:37:46Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 40e3863:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

AtishayMsft · 2023-10-02T15:40:13Z

/azp run Fluent UI React - PR and CI

azure-pipelines · 2023-10-02T15:40:25Z

Azure Pipelines successfully started running 1 pipeline(s).

Shubhabrata08 · 2023-10-02T15:57:32Z

Finalized the scaling logic

@AtishayMsft

AtishayMsft · 2023-10-02T16:08:57Z

/azp run Fluent UI React - PR and CI

azure-pipelines · 2023-10-02T16:09:09Z

Azure Pipelines successfully started running 1 pipeline(s).

…inimum-height-feature-bar-chart

Shubhabrata08 · 2023-10-03T11:22:24Z

@microsoft-github-policy-service agree

azure-pipelines · 2023-10-03T11:39:28Z

Commenter does not have sufficient privileges for PR 29359 in repo microsoft/fluentui

Shubhabrata08 · 2023-10-03T11:41:27Z

@AtishayMsft , I have added the changelog as well.

AtishayMsft · 2023-10-03T16:57:30Z

/azp run Fluent UI React - PR and CI

azure-pipelines · 2023-10-03T16:57:42Z

Azure Pipelines successfully started running 1 pipeline(s).

Shubhabrata08 · 2023-10-03T17:57:26Z

@AtishayMsft Please have a look at the changes for the Vertical stacked charts

…inimum-height-feature-bar-chart

Shubhabrata08 · 2023-10-04T10:31:45Z

@AtishayMsft Are there any more changes required in this issue?

AtishayMsft · 2023-10-04T10:47:08Z

/azp run Fluent UI React - PR and CI

azure-pipelines · 2023-10-04T10:47:20Z

Azure Pipelines successfully started running 1 pipeline(s).

…inimum-height-feature-bar-chart

…/Shubhabrata08/fluentui into minimum-height-feature-bar-chart

AtishayMsft · 2023-10-04T11:20:32Z

/azp run Fluent UI React - PR and CI

azure-pipelines · 2023-10-04T11:20:44Z

Azure Pipelines successfully started running 1 pipeline(s).

AtishayMsft · 2023-10-04T13:56:13Z

/azp run Fluent UI React - PR and CI

azure-pipelines · 2023-10-04T13:56:27Z

Azure Pipelines successfully started running 1 pipeline(s).

…inimum-height-feature-bar-chart

AtishayMsft · 2023-10-04T16:19:59Z

/azp run Fluent UI React - PR and CI

azure-pipelines · 2023-10-04T16:20:12Z

Azure Pipelines successfully started running 1 pipeline(s).

AtishayMsft · 2023-10-04T16:28:36Z

/azp help

azure-pipelines · 2023-10-04T16:28:42Z

Supported commands help: Get descriptions, examples and documentation about supported commands Example: help "command_name" list: List all pipelines for this repository using a comment. Example: "list" run: Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run. Example: "run" or "run pipeline_name, pipeline_name, pipeline_name" where: Report back the Azure DevOps orgs that are related to this repository and org Example: "where" See additional documentation.

AtishayMsft · 2023-10-04T16:29:42Z

/azp list

azure-pipelines · 2023-10-04T16:29:47Z

CI/CD Pipelines for this repository: Size Auditor Bot on Azure Dev Ops (rush) Fluent UI React - PR and CI Size Auditor Bot on Azure Dev Ops (yaml) Fluent UI React - Perf-Test Visual Regression Tool - PR

AtishayMsft · 2023-10-04T16:31:25Z

/azp run

azure-pipelines · 2023-10-04T16:31:52Z

Azure Pipelines successfully started running 4 pipeline(s).

fabricteam · 2023-10-04T16:50:11Z

📊 Bundle size report

_{🤖 This report was generated against 401ff6d9af9536b24ab3c52c658127d19706e030}

fabricteam · 2023-10-04T16:56:10Z

🕵 fluentuiv8 No visual regressions between this PR and main

size-auditor · 2023-10-04T17:00:49Z

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 401ff6d9af9536b24ab3c52c658127d19706e030 (build)

* master: (35 commits) bugfix(react-dialog): removes context hooks invocations from styles hook (microsoft#29396) chore(react-dialog): exports DialogSurface context types and hooks (microsoft#29397) Minimum height feature for bar chart (microsoft#29359) (feat) Breadcrumb - register items via context (microsoft#29393) fix: Consider all parents as scroll parents (microsoft#29378) Changes to enable charting on fluent docsite (microsoft#29210) bugfix: ensure TreeItem emits events properly (microsoft#29390) chore(deps): bump get-func-name from 2.0.0 to 2.0.2 (microsoft#29320) chore: migrate from getNativeElementProps to getIntrinsicElementProps (microsoft#29387) applying package updates applying package updates fix: Icon in disabled Button shouldn't change color on hover or pressed (microsoft#29342) Squish changes for rebase (microsoft#28705) fix: GroupedListV2 scrollToIndex now works correctly (microsoft#29332) Fix 27482: ProgressBar has an optional state variable (microsoft#29366) remove a11y test ux from theme designer (microsoft#29379) feat: preview release (microsoft#29377) Fixed divider in the tooltip (microsoft#29357) fix (microsoft#29376) docs: Initial documentation pass (microsoft#29372) ...

Shubhabrata08 added 3 commits October 2, 2023 20:20

Sets scaled height to 1 if value is relatively very small

83c6e64

Minor code cleanup

e767474

Merge branch 'master' of https://github.com/microsoft/fluentui into m…

0fb963a

…inimum-height-feature-bar-chart

Shubhabrata08 requested a review from a team as a code owner October 2, 2023 15:21

Shubhabrata08 added 2 commits October 2, 2023 20:53

Removed unnecessary line

60703df

Restored debugging changes

0bdaa2c

Updated scaling logic

fb2803b

Shubhabrata08 added 2 commits October 3, 2023 16:46

Merge branch 'master' of https://github.com/microsoft/fluentui into m…

e67d71b

…inimum-height-feature-bar-chart

yarn change

384b2ad

AtishayMsft reviewed Oct 3, 2023

View reviewed changes

Comment thread packages/react-charting/src/components/VerticalBarChart/VerticalBarChart.base.tsx

AtishayMsft reviewed Oct 3, 2023

View reviewed changes

Comment thread packages/react-charting/src/components/VerticalBarChart/VerticalBarChart.base.tsx

AtishayMsft reviewed Oct 3, 2023

View reviewed changes

Comment thread change/@fluentui-react-charting-8bdce3b1-3bbd-4a1d-8000-3cd8b50e1d0c.json

Added the feature to Vertical Stacked Charts as well

4a6c3b4

Merge branch 'master' of https://github.com/microsoft/fluentui into m…

d891733

…inimum-height-feature-bar-chart

AtishayMsft added the Package: charting label Oct 4, 2023

Merge branch 'master' into minimum-height-feature-bar-chart

385197e

AtishayMsft reviewed Oct 4, 2023

View reviewed changes

Comment thread packages/react-charting/src/components/VerticalStackedBarChart/VerticalStackedBarChart.base.tsx Outdated

Shubhabrata08 added 3 commits October 4, 2023 16:39

Merge branch 'master' of https://github.com/microsoft/fluentui into m…

cfa9fa4

…inimum-height-feature-bar-chart

Rremoving redundant code

3c3b857

Merge branch 'minimum-height-feature-bar-chart' of https://github.com…

6124318

…/Shubhabrata08/fluentui into minimum-height-feature-bar-chart

AtishayMsft approved these changes Oct 4, 2023

View reviewed changes

AtishayMsft enabled auto-merge (squash) October 4, 2023 13:30

Merge branch 'master' of https://github.com/microsoft/fluentui into m…

40e3863

…inimum-height-feature-bar-chart

AtishayMsft merged commit b4611f7 into microsoft:master Oct 4, 2023

AtishayMsft mentioned this pull request Oct 26, 2023

Added scale factor to minHeight logic #29653

Merged

Uh oh!

Conversation

Shubhabrata08 commented Oct 2, 2023

New Behavior

Related Issue(s)

Uh oh!

codesandbox-ci Bot commented Oct 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AtishayMsft commented Oct 2, 2023

Uh oh!

azure-pipelines Bot commented Oct 2, 2023

Uh oh!

Shubhabrata08 commented Oct 2, 2023

Uh oh!

AtishayMsft commented Oct 2, 2023

Uh oh!

azure-pipelines Bot commented Oct 2, 2023

Uh oh!

Shubhabrata08 commented Oct 3, 2023

Uh oh!

azure-pipelines Bot commented Oct 3, 2023

Uh oh!

Shubhabrata08 commented Oct 3, 2023

Uh oh!

AtishayMsft commented Oct 3, 2023

Uh oh!

azure-pipelines Bot commented Oct 3, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Shubhabrata08 commented Oct 3, 2023

Uh oh!

Shubhabrata08 commented Oct 4, 2023

Uh oh!

AtishayMsft commented Oct 4, 2023

Uh oh!

azure-pipelines Bot commented Oct 4, 2023

Uh oh!

Uh oh!

AtishayMsft commented Oct 4, 2023

Uh oh!

azure-pipelines Bot commented Oct 4, 2023

Uh oh!

AtishayMsft commented Oct 4, 2023

Uh oh!

azure-pipelines Bot commented Oct 4, 2023

Uh oh!

AtishayMsft commented Oct 4, 2023

Uh oh!

azure-pipelines Bot commented Oct 4, 2023

Uh oh!

AtishayMsft commented Oct 4, 2023

Uh oh!

azure-pipelines Bot commented Oct 4, 2023

Uh oh!

AtishayMsft commented Oct 4, 2023

Uh oh!

azure-pipelines Bot commented Oct 4, 2023

Uh oh!

AtishayMsft commented Oct 4, 2023

Uh oh!

azure-pipelines Bot commented Oct 4, 2023

Uh oh!

fabricteam commented Oct 4, 2023

📊 Bundle size report

Uh oh!

fabricteam commented Oct 4, 2023

🕵 fluentuiv8 No visual regressions between this PR and main

Uh oh!

size-auditor Bot commented Oct 4, 2023

Asset size changes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

codesandbox-ci Bot commented Oct 2, 2023 •

edited

Loading