Updated TooltipBestPractices to include new best practices#29284
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3f7c1ec:
|
smhigley
reviewed
Sep 25, 2023
smhigley
left a comment
smhigley
left a comment
Contributor
There was a problem hiding this comment.
Just the one suggestion, otherwise it LGTM!
…tices.md Co-authored-by: Sarah Higley <[email protected]>
microsoft-github-policy-service
Bot
added
Area: Documentation
Component: Tooltip
labels
smhigley
approved these changes
Sep 25, 2023
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
Collaborator
📊 Bundle size report🤖 This report was generated against 5b6536c989c9ebb2bf4010fbf18dfb50b570b2c6 |
khmakoto
approved these changes
Sep 25, 2023
Asset size changesUnable to find bundle size details for Baseline commit: 5b6536c Possible causes
Recommendations
|
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Sep 26, 2023
* master: fix(react-dialog): use makeResetStyles for base dialog components styles (microsoft#29280) chore(react-tags-preview): update props descriptions (microsoft#29287) chore: bump swc core to mitigate transpilation memory leaks (microsoft#29253) feat: adds customizeSelector to createCustomFocusIndicatorStyle method (microsoft#29209) applying package updates Updated TooltipBestPractices to include accessibility best practices (microsoft#29284) fix: BreadcrumbItem should use makeResetStyles for base styles (microsoft#29278)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Tooltip read me best practices did not have guidelines on non-interactive elements.
New Behavior
Tooltip read me best practices now has guidelines on non-interactive elements.
Related Issue(s)