Skip to content

fix(react-tags-preview): update handleTagDismiss type#29240

Merged
YuanboXue-Amber merged 5 commits into
microsoft:masterfrom
YuanboXue-Amber:yuanboxue/tag-4
Sep 22, 2023
Merged

fix(react-tags-preview): update handleTagDismiss type#29240
YuanboXue-Amber merged 5 commits into
microsoft:masterfrom
YuanboXue-Amber:yuanboxue/tag-4

Conversation

@YuanboXue-Amber

@YuanboXue-Amber YuanboXue-Amber commented Sep 21, 2023

Copy link
Copy Markdown
Contributor

handleTagDismiss is passed down from TagGroupContext to each tag/interaction tag to handle dismiss.

  • before:
    handleTagDismiss: (e: React.MouseEvent | React.KeyboardEvent, value: Value) => void;
  • after - update the second argument from value to data: { value }:
    type TagDismissData<Value = TagValue> = {
      value: Value;
    };
    type TagDismissEvent = React.MouseEvent | React.KeyboardEvent;
    type TagDismissHandler<Value = TagValue> = (e: TagDismissEvent, data: TagDismissData<Value>) => void;
    
    handleTagDismiss: TagDismissHandler<Value>;

@fabricteam

fabricteam commented Sep 21, 2023

Copy link
Copy Markdown
Collaborator

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-tags-preview
InteractionTag
14.23 kB
5.722 kB
14.23 kB
5.723 kB

1 B
react-tags-preview
Tag
29.985 kB
9.667 kB
30.001 kB
9.672 kB
16 B
5 B
react-tags-preview
TagGroup
72.871 kB
21.705 kB
72.851 kB
21.693 kB
-20 B
-12 B

🤖 This report was generated against 01d9fdb588ee13cd881e9c053d13e8b8e54b3bcf

@codesandbox-ci

codesandbox-ci Bot commented Sep 21, 2023

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8da3372:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam

fabricteam commented Sep 21, 2023

Copy link
Copy Markdown
Collaborator

🕵 fluentuiv9 No visual regressions between this PR and main

@size-auditor

size-auditor Bot commented Sep 21, 2023

Copy link
Copy Markdown

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 01d9fdb588ee13cd881e9c053d13e8b8e54b3bcf (build)

@YuanboXue-Amber YuanboXue-Amber marked this pull request as ready for review September 22, 2023 10:08
@YuanboXue-Amber YuanboXue-Amber requested review from a team as code owners September 22, 2023 10:08
Comment thread packages/react-components/react-tags-preview/src/utils/types.ts Outdated
@YuanboXue-Amber YuanboXue-Amber enabled auto-merge (squash) September 22, 2023 12:06
@YuanboXue-Amber

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 4 pipeline(s).

@YuanboXue-Amber YuanboXue-Amber merged commit 53ce54c into microsoft:master Sep 22, 2023
@YuanboXue-Amber YuanboXue-Amber deleted the yuanboxue/tag-4 branch September 22, 2023 14:02
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Sep 25, 2023
…s-classnames

* master:
  chore: Updating @fluentui/react-icons to version 2.0.216 (microsoft#29151)
  Replace cxe-coastal with cxe-red in codeowners (microsoft#29248)
  feat(react-drawer): add support to override Dialog as slot (microsoft#29217)
  fix(react-tags-preview): update `handleTagDismiss` type (microsoft#29240)
  create TimePicker component (microsoft#29252)
  Create react-timepicker-compat-preview package (microsoft#29216)
  feat(react-tags-preview): add useCustomStyleHook_unstable to all components (microsoft#29237)
  Enable reflow for all cartesian chart examples (microsoft#29229)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants