feat(react-drawer): add support to override Dialog as slot#29217
Merged
marcosmoura merged 1 commit intoSep 22, 2023
Merged
Conversation
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 637 | 639 | 5000 | |
| Button | mount | 316 | 315 | 5000 | |
| Field | mount | 1102 | 1116 | 5000 | |
| FluentProvider | mount | 715 | 710 | 5000 | |
| FluentProviderWithTheme | mount | 82 | 82 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 71 | 60 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 72 | 77 | 10 | |
| InfoButton | mount | 12 | 10 | 5000 | |
| MakeStyles | mount | 846 | 865 | 50000 | |
| Persona | mount | 1755 | 1661 | 5000 | |
| SpinButton | mount | 1344 | 1337 | 5000 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f187aee:
|
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 979322ae432426868be11b010d88b9c1b37c0c0d (build) |
ValentinaKozlova
approved these changes
Sep 22, 2023
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Sep 25, 2023
…s-classnames * master: chore: Updating @fluentui/react-icons to version 2.0.216 (microsoft#29151) Replace cxe-coastal with cxe-red in codeowners (microsoft#29248) feat(react-drawer): add support to override Dialog as slot (microsoft#29217) fix(react-tags-preview): update `handleTagDismiss` type (microsoft#29240) create TimePicker component (microsoft#29252) Create react-timepicker-compat-preview package (microsoft#29216) feat(react-tags-preview): add useCustomStyleHook_unstable to all components (microsoft#29237) Enable reflow for all cartesian chart examples (microsoft#29229)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
<Dialog>was a fixed React node.New Behavior
Create Dialog from slot allowing overrides.