fix(react-accordion): fix memory leak caused by context assignment#29193
Merged
layershifter merged 2 commits intoSep 20, 2023
Merged
Conversation
Hotell
approved these changes
Sep 20, 2023
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3958902:
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| InfoButton | mount | 15 | 16 | 5000 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 627 | 653 | 5000 | |
| Button | mount | 306 | 335 | 5000 | |
| Field | mount | 1117 | 1092 | 5000 | |
| FluentProvider | mount | 680 | 697 | 5000 | |
| FluentProviderWithTheme | mount | 81 | 80 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 71 | 72 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 78 | 71 | 10 | |
| InfoButton | mount | 15 | 16 | 5000 | Possible regression |
| MakeStyles | mount | 855 | 839 | 50000 | |
| Persona | mount | 1753 | 1710 | 5000 | |
| SpinButton | mount | 1358 | 1372 | 5000 |
Collaborator
📊 Bundle size report
Unchanged fixtures
|
Asset size changesUnable to find bundle size details for Baseline commit: b824db7 Possible causes
Recommendations
|
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
ling1726
approved these changes
Sep 20, 2023
Member
Author
|
Force merged to unblock upgrade of Fluent in Teams: approvals from team members are present, CI is green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Accordioncauses memory leaks.New Behavior
Accordiondoes not cause memory leaks via a workaround.Related Issue(s)