Skip to content

Breadcrumb design team fixes#28883

Merged
ValentinaKozlova merged 4 commits into
microsoft:masterfrom
ValentinaKozlova:breadcrumb-design-team-fixes
Aug 18, 2023
Merged

Breadcrumb design team fixes#28883
ValentinaKozlova merged 4 commits into
microsoft:masterfrom
ValentinaKozlova:breadcrumb-design-team-fixes

Conversation

@ValentinaKozlova

Copy link
Copy Markdown
Contributor

Changes requested by the design team:

  • Disable Link component. If nobody needs it, we'll remove it
  • Remove spacing for small non-interactive items

Previous Behavior

image
image

New Behavior

image
image

@codesandbox-ci

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 601664d:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam

Copy link
Copy Markdown
Collaborator

📊 Bundle size report

🤖 This report was generated against e40f1181983bbf4b0926cd15fb8dbc7a9e3188a3

@size-auditor

size-auditor Bot commented Aug 16, 2023

Copy link
Copy Markdown

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: e40f1181983bbf4b0926cd15fb8dbc7a9e3188a3 (build)

@ValentinaKozlova ValentinaKozlova marked this pull request as ready for review August 17, 2023 14:50
@ValentinaKozlova ValentinaKozlova requested a review from a team as a code owner August 17, 2023 14:50
@ValentinaKozlova ValentinaKozlova merged commit 039d87e into microsoft:master Aug 18, 2023
@ValentinaKozlova ValentinaKozlova deleted the breadcrumb-design-team-fixes branch August 18, 2023 14:54
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Aug 21, 2023
* master:
  fix(react-drawer): rename values of position prop from left/right to start/end (microsoft#28905)
  Breadcrumb design team fixes (microsoft#28883)
  applying package updates
  chore(react-search-preview): migrate to new slots API (microsoft#28862)
  docs: Updating version of CDN used and replacing usage of via.placeholder.com with SVG from CDN (microsoft#28895)
  fix(DatePicker, react-datepicker-compat): Make year picker react to go to today button (microsoft#28907)
  fix(DatePicker): readOnlyTextField styles should win over default TextField's (microsoft#28891)
  chore: fix lint warnings for @fluentui/react (microsoft#28888)
  Lint: fix fluent v9 warnings (microsoft#28889)
  doc: add drag & drop example (microsoft#28821)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants