Skip to content

Add mountnode datepicker compat#28747

Merged
GeoffCoxMSFT merged 9 commits into
microsoft:masterfrom
GeoffCoxMSFT:add-mountnode-datepicker-compat
Aug 9, 2023
Merged

Add mountnode datepicker compat#28747
GeoffCoxMSFT merged 9 commits into
microsoft:masterfrom
GeoffCoxMSFT:add-mountnode-datepicker-compat

Conversation

@GeoffCoxMSFT

Copy link
Copy Markdown
Member

Summary

Allows callers to change the mountNode of the portal used to display the dropdown part for DatePicker compat.

Changes

  • Added mountNode property to props and state
  • Updated use hook to set state from props
  • Updated render to pass mountNode to Portal

Issues

Fixes #28625

@GeoffCoxMSFT GeoffCoxMSFT self-assigned this Aug 4, 2023
@GeoffCoxMSFT GeoffCoxMSFT requested review from a team, khmakoto and sopranopillow as code owners August 4, 2023 19:30
@github-actions github-actions Bot added this to the August Project Cycle Q4 2023 milestone Aug 4, 2023
@fabricteam

fabricteam commented Aug 4, 2023

Copy link
Copy Markdown
Collaborator

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-datepicker-compat
DatePicker Compat
206.915 kB
57.343 kB
206.963 kB
57.362 kB
48 B
19 B

🤖 This report was generated against 76f48d39e3361f68ae7e9c42b6e98395b75ec5d3

@codesandbox-ci

codesandbox-ci Bot commented Aug 4, 2023

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9ea8210:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam

fabricteam commented Aug 4, 2023

Copy link
Copy Markdown
Collaborator

🕵 fluentuiv9 No visual regressions between this PR and main

@size-auditor

size-auditor Bot commented Aug 4, 2023

Copy link
Copy Markdown

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 76f48d39e3361f68ae7e9c42b6e98395b75ec5d3 (build)

GeoffCoxMSFT and others added 3 commits August 7, 2023 15:47
…ts/DatePicker/DatePicker.types.ts

Co-authored-by: Makoto Morimoto <[email protected]>
…ts/DatePicker/DatePicker.types.ts

Co-authored-by: Makoto Morimoto <[email protected]>
@GeoffCoxMSFT GeoffCoxMSFT enabled auto-merge (squash) August 8, 2023 21:28
@GeoffCoxMSFT GeoffCoxMSFT merged commit 227120f into microsoft:master Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Add mountNode property to Combobox

3 participants