Skip to content

feat: RTL support and rename#28151

Merged
ling1726 merged 3 commits into
microsoft:masterfrom
ling1726:react-toast/feat/rtl
Jun 6, 2023
Merged

feat: RTL support and rename#28151
ling1726 merged 3 commits into
microsoft:masterfrom
ling1726:react-toast/feat/rtl

Conversation

@ling1726

@ling1726 ling1726 commented Jun 6, 2023

Copy link
Copy Markdown
Contributor

Renames left/right in the codebase to be start/end. Also updates the positioning styles to take text direction into account.

image

Fixes #27772

Renames left/right in the codebase to be start/end. Also updates the
positioning styles to take text direction into account.
@ling1726 ling1726 force-pushed the react-toast/feat/rtl branch from 5beaa28 to 3842f18 Compare June 6, 2023 08:14
@fabricteam

fabricteam commented Jun 6, 2023

Copy link
Copy Markdown
Collaborator

📊 Bundle size report

🤖 This report was generated against 5af71db9148e6f133c87eca01672c31f87e1a460

@ling1726 ling1726 marked this pull request as ready for review June 6, 2023 08:22
@ling1726 ling1726 requested a review from a team as a code owner June 6, 2023 08:22
@size-auditor

size-auditor Bot commented Jun 6, 2023

Copy link
Copy Markdown

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 5af71db9148e6f133c87eca01672c31f87e1a460 (build)

@codesandbox-ci

codesandbox-ci Bot commented Jun 6, 2023

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a40c0a9:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@ling1726 ling1726 merged commit 8f51f15 into microsoft:master Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support RTL positions

5 participants