Skip to content

feat: Implement ToastTrigger component#28031

Merged
ling1726 merged 5 commits into
microsoft:masterfrom
ling1726:react-toast/feat/toast-trigger
May 30, 2023
Merged

feat: Implement ToastTrigger component#28031
ling1726 merged 5 commits into
microsoft:masterfrom
ling1726:react-toast/feat/toast-trigger

Conversation

@ling1726

@ling1726 ling1726 commented May 29, 2023

Copy link
Copy Markdown
Contributor

Implements the ToastTrigger component to allow users to create actions that dismiss the Toast easily - follows the same pattern as all other triggers in the library

Fixes #27771

Implements the ToastTrigger component to allow users to create actions
that dismiss the Toast easily

Fixes microsoft#27771
@fabricteam

fabricteam commented May 29, 2023

Copy link
Copy Markdown
Collaborator

📊 Bundle size report

🤖 This report was generated against d3ececdc5c2916d98e434bfd0422e1e1541ac080

@size-auditor

size-auditor Bot commented May 29, 2023

Copy link
Copy Markdown

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: d3ececdc5c2916d98e434bfd0422e1e1541ac080 (build)

@codesandbox-ci

codesandbox-ci Bot commented May 29, 2023

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8fc4428:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

Comment thread tools/tsconfig.generated.json Outdated

@bsunderhus bsunderhus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@ling1726 ling1726 enabled auto-merge (squash) May 30, 2023 08:14
@ling1726 ling1726 merged commit 6032933 into microsoft:master May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement ToastTrigger

6 participants