fix(react-datepicker-compat): Error handling story now doesn't use Date.now to avoid SSR errors#27988

Merged

layershifter merged 1 commit into

microsoft:masterfrom

sopranopillow:react-datepicker-compat/labels-fix

May 25, 2023

sopranopillow commented May 24, 2023

Contributor

Previous Behavior

Error handling story uses Date.now()

New Behavior

Error handling story doesn't use Date.now() instead it uses a specific date.

Related Issue(s)

Fixes [Bug]: labels in stories are not SSR safe #27957


          fix: ErrorHandling story now doesn't use Date.now to avoid ssr errors

3a6cfb4

sopranopillow added Fluent UI react-components (v9) Component: DatePickerCompat labels

sopranopillow added this to the May Project Cycle Q2 2023 milestone

sopranopillow self-assigned this

sopranopillow requested review from a team and khmakoto as code owners

May 24, 2023 17:44

khmakoto approved these changes

View reviewed changes

sopranopillow commented May 24, 2023 •

edited

Loading

Contributor Author

@layershifter I was not able to repro the steps you gave in the original issue, in my local machine everything works. I am guessing that the error comes from Date.now() and therefore the server timezone/time messes up with that. Let me know if maybe I'm thinking of the wrong thing here, thanks!

For some more clarification, I cloned your PR and went through the steps you provided.

sopranopillow requested a review from layershifter

May 24, 2023 17:47

codesandbox-ci Bot commented May 24, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3a6cfb4:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

fabricteam commented May 24, 2023

Collaborator

📊 Bundle size report

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`react-datepicker-compat` DatePicker Compat	`221.446 kB` `58.861 kB`

_{🤖 This report was generated against 0e26a2c598d52a6399af2b5e73deffad3649f4b9}

size-auditor Bot commented May 24, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 0e26a2c598d52a6399af2b5e73deffad3649f4b9 (build)

fabricteam commented May 24, 2023

Collaborator

🕵 fluentuiv9 No visual regressions between this PR and main

layershifter approved these changes

View reviewed changes

layershifter left a comment

Member

All good, thanks 👍

layershifter merged commit 8f7c1b7 into microsoft:master

sopranopillow deleted the react-datepicker-compat/labels-fix branch

May 25, 2023 15:35

msft-fluent-ui-bot commented May 26, 2023

Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented May 26, 2023

Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented May 26, 2023

Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented May 26, 2023

Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented May 26, 2023

Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented May 26, 2023

Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented May 26, 2023

Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented May 26, 2023

Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented May 26, 2023

Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented May 26, 2023

Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented May 26, 2023

Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented May 26, 2023

Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented May 26, 2023

Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented May 26, 2023

Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented May 26, 2023

Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented May 26, 2023

Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented May 26, 2023

Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented May 26, 2023

Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented May 26, 2023

Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented May 26, 2023

Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented May 26, 2023

Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented May 26, 2023

Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented May 26, 2023

Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented May 26, 2023

Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented May 26, 2023

Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented May 26, 2023

Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented May 26, 2023

Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot mentioned this pull request

[Bug]: labels in stories are not SSR safe #27957

Closed

4 tasks

msft-fluent-ui-bot commented May 26, 2023

Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented May 26, 2023

Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented May 26, 2023

Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented May 26, 2023

Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented May 26, 2023

Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented May 26, 2023

Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented May 26, 2023

Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented May 26, 2023

Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented May 26, 2023

Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented May 26, 2023

Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented May 26, 2023

Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented May 26, 2023

Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented May 26, 2023

Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented May 26, 2023

Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented May 26, 2023

Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: DatePickerCompat Fluent UI react-components (v9)