feat(react-tags): make basic Tag a button instead of div#27858
Merged
Conversation
YuanboXue-Amber
changed the title
Collaborator
📊 Bundle size report
🤖 This report was generated against 06cd515eda59a3078bfe32f9cc7c1f281cd20208 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ce95959:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 06cd515eda59a3078bfe32f9cc7c1f281cd20208 (build) |
ling1726
reviewed
May 16, 2023
ling1726
approved these changes
May 16, 2023
ling1726
left a comment
ling1726
left a comment
Contributor
There was a problem hiding this comment.
Root tag being a button makes so much more sense, and it looks nicer than a dismiss button IMO
…lues.ts Co-authored-by: ling1726 <[email protected]>
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
May 18, 2023
* master: (24 commits) chore(react-tabster): upgrade tabster to v4.4.2 (microsoft#27540) feat(react-tags): Add TagGroup with context (microsoft#27886) applying package updates fix(react-infobutton): Add aria-owns to InfoLabel (microsoft#27834) fix(recipes-react-components): Add a FluentProvider to the local storybook (microsoft#27746) chore: update RFC template (microsoft#27880) applying package updates feat: implement Toaster offset (microsoft#27854) feat(react-drawer): create DrawerFooter component (microsoft#27583) Make getKey and selection props mutually exclusive (microsoft#24048) Added MIGRATION.md to the Breadcrumb (microsoft#27846) update Github CODEOWNERS file (microsoft#27849) feat(react-tags): make basic Tag a button instead of div (microsoft#27858) chore: add test-ssr script to v9 packages (microsoft#27690) chore(react-tree): exports TreeItemAside unstable (microsoft#27856) bugfix(react-dialog): removes unnecessary grid gaps (microsoft#27845) applying package updates fix(react-textarea): Don't remove outline when filled and disabled and apply correct disabled color to text (microsoft#27837) feat: Implement limit for toast stacking (microsoft#27848) Update README.md for fluent 2 theme to include import instructions (microsoft#27847) ...
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
May 18, 2023
* feat/drawer-header: (24 commits) chore(react-tabster): upgrade tabster to v4.4.2 (microsoft#27540) feat(react-tags): Add TagGroup with context (microsoft#27886) applying package updates fix(react-infobutton): Add aria-owns to InfoLabel (microsoft#27834) fix(recipes-react-components): Add a FluentProvider to the local storybook (microsoft#27746) chore: update RFC template (microsoft#27880) applying package updates feat: implement Toaster offset (microsoft#27854) feat(react-drawer): create DrawerFooter component (microsoft#27583) Make getKey and selection props mutually exclusive (microsoft#24048) fix: move style override to outside the component Added MIGRATION.md to the Breadcrumb (microsoft#27846) update Github CODEOWNERS file (microsoft#27849) feat(react-tags): make basic Tag a button instead of div (microsoft#27858) chore: add test-ssr script to v9 packages (microsoft#27690) chore(react-tree): exports TreeItemAside unstable (microsoft#27856) bugfix(react-dialog): removes unnecessary grid gaps (microsoft#27845) applying package updates fix(react-textarea): Don't remove outline when filled and disabled and apply correct disabled color to text (microsoft#27837) feat: Implement limit for toast stacking (microsoft#27848) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Before this PR, basic Tag has
dismissButtonslot to dismiss itself. This PR make the Tag itself a button that does dismiss, and changesdismissButtonslot todismissIcon. And this PR keeps TagButton unchanged - it's still two buttons.before
after
Why this change:
In fluent v0 Pill, the focus ring is around the entire Pill. We would want the same for v9 basic Tag. Also this is useful for user with magnifier that tracks focus.
What does this mean for feat(react-tags): replace TagButton with Tag
interactiveprop #27794:I will keep two controls Tag/TagButton instead of one Tag, and close PR 27794. Because basic Tag and TagButton have different slots. The differences are:
Slot<span>), while TagButton has dismiss button (Slot<button>)contentslot that wraps around media/primary and secondary text and act as first tab stop. Basic Tag does not needcontentslot.