chore: enforce files naming to use .styles.ts [cxe-coastal]#27708
Merged
layershifter merged 1 commit intoMay 3, 2023
Merged
Conversation
layershifter
force-pushed
the
chore/enforce-files-naming-cxe-coastal
branch
3 times, most recently
from
8964bbc to
2231dfc
Compare
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 882 | 874 | 5000 | |
| Button | mount | 437 | 474 | 5000 | |
| Field | mount | 1551 | 1504 | 5000 | |
| FluentProvider | mount | 1154 | 1128 | 5000 | |
| FluentProviderWithTheme | mount | 132 | 137 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 117 | 115 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 125 | 140 | 10 | |
| InfoButton | mount | 25 | 27 | 5000 | |
| MakeStyles | mount | 1369 | 1397 | 50000 | |
| Persona | mount | 2355 | 2354 | 5000 | |
| SpinButton | mount | 1946 | 1877 | 5000 |
7 tasks
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 6d0848597a7c07883a93b13f67f6727fd791f3dd (build) |
Collaborator
📊 Bundle size reportUnchanged fixtures
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e0cc475:
|
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
layershifter
requested review from
a team,
GeoffCoxMSFT,
TristanWatanabe,
micahgodbolt and
smhigley
as code owners
layershifter
force-pushed
the
chore/enforce-files-naming-cxe-coastal
branch
from
2231dfc to
f24abab
Compare
khmakoto
reviewed
May 1, 2023
layershifter
force-pushed
the
chore/enforce-files-naming-cxe-coastal
branch
from
f24abab to
dcc4e37
Compare
github-actions
Bot
modified the milestones:
April Project Cycle Q2 2023,
May Project Cycle Q2 2023
layershifter
force-pushed
the
chore/enforce-files-naming-cxe-coastal
branch
from
dcc4e37 to
be4886e
Compare
khmakoto
approved these changes
May 2, 2023
layershifter
force-pushed
the
chore/enforce-files-naming-cxe-coastal
branch
from
be4886e to
e0cc475
Compare
Collaborator
|
🎉 Handy links: |
Collaborator
|
🎉 Handy links: |
Collaborator
|
🎉 Handy links: |
Collaborator
|
🎉 Handy links: |
Collaborator
|
🎉 Handy links: |
Collaborator
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Behavior
This PR removes
useCOMPONENTStyles.tsfiles touseCOMPONENTStyles.styles.tsfiles to follow Griffel's rule for naming files.The ESLint rule have not been enabled yet, this PR is a preparation to do that. Affects files owned by @microsoft/cxe-coastal
Change files are set to patch/prerelease as artifacts should be updated.
Related Issue(s)