Skip to content

Doc: Add/Remove TreeItem and useFlatTree stories#27515

Merged
bsunderhus merged 19 commits into
microsoft:masterfrom
petdud:tree-new-stories
Apr 13, 2023
Merged

Doc: Add/Remove TreeItem and useFlatTree stories#27515
bsunderhus merged 19 commits into
microsoft:masterfrom
petdud:tree-new-stories

Conversation

@petdud

@petdud petdud commented Apr 11, 2023

Copy link
Copy Markdown
Contributor

Previous Behavior

New Behavior

This PR adds new stories:

  • Add/Remove TreeItem
  • useFlatTree hook, which was deleted by mistake in previous PR

Related Issue(s)

  • Fixes #

@fabricteam

fabricteam commented Apr 11, 2023

Copy link
Copy Markdown
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
68.075 kB
18.416 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
207.606 kB
57.581 kB
react-components
react-components: FluentProvider & webLightTheme
38.778 kB
12.337 kB
react-portal-compat
PortalCompatProvider
6.446 kB
2.185 kB
🤖 This report was generated against bbdfcb9795bca865f8b632f30ee5c7156e092fc5

@codesandbox-ci

codesandbox-ci Bot commented Apr 11, 2023

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 39f7928:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam

fabricteam commented Apr 11, 2023

Copy link
Copy Markdown
Collaborator

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
InfoButton mount 20 18 5000 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 710 699 5000
Button mount 397 403 5000
Field mount 1219 1222 5000
FluentProvider mount 776 774 5000
FluentProviderWithTheme mount 117 110 10
FluentProviderWithTheme virtual-rerender 97 90 10
FluentProviderWithTheme virtual-rerender-with-unmount 96 102 10
InfoButton mount 20 18 5000 Possible regression
MakeStyles mount 1179 1178 50000
Persona mount 1916 1851 5000
SpinButton mount 1485 1443 5000

@size-auditor

size-auditor Bot commented Apr 11, 2023

Copy link
Copy Markdown

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: bbdfcb9795bca865f8b632f30ee5c7156e092fc5 (build)

@petdud petdud changed the title Add/Remove tree item Tree stories: Add/Remove TreeItem, LazyLoading and useFlatTree Apr 11, 2023
@petdud petdud marked this pull request as ready for review April 11, 2023 13:39
@petdud petdud requested a review from a team as a code owner April 11, 2023 13:39
@petdud petdud changed the title Tree stories: Add/Remove TreeItem, LazyLoading and useFlatTree Tree stories: Add/Remove TreeItem and useFlatTree Apr 12, 2023
@bsunderhus bsunderhus assigned petdud and unassigned smhigley Apr 12, 2023
@bsunderhus bsunderhus changed the title Tree stories: Add/Remove TreeItem and useFlatTree Doc: Add/Remove TreeItem and useFlatTree stories Apr 12, 2023
Comment thread packages/react-components/react-tree/stories/Tree/TreeLazyLoading.stories.tsx Outdated
@bsunderhus bsunderhus merged commit e5c39d1 into microsoft:master Apr 13, 2023
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Apr 13, 2023
…t/drawer-light-dismiss-prop

* marcosmoura/feat/drawer-component: (51 commits)
  fix: upgrade react-dialog
  Doc: Add/Remove TreeItem and useFlatTree stories (microsoft#27515)
  applying package updates
  Fix accessibility labels for tree stories (microsoft#27443)
  fix: BasePickerListBelow aria-describedby with values (microsoft#27525)
  chore: Remove deprecated InputField, etc. shim components (microsoft#27492)
  [Feature]: allow aria-description attribute on v9 (microsoft#27478)
  feat(react-jsx-runtime): implements custom JSX pragma (microsoft#27472)
  chore: update generator to include "test-ssr" script (microsoft#27463)
  applying package updates
  fix: add "style" to exports field (microsoft#27274)
  applying package updates
  feat(react-datepicker-compat): Make package public (microsoft#27524)
  fix: react-combobox defines fallbackPositions for popup on small screens (microsoft#27521)
  fix: use tabster to focus on trigger, instead of manually invoking .focus (microsoft#27512)
  add cxe-red to react-shared-context ownership (microsoft#27296)
  docs: add props tables for all exported Popover controls (microsoft#27503)
  fix: Update FormFieldShim to work with Field context changes (microsoft#27436)
  Fix wrong state narration for multiple selected legends (microsoft#27429)
  add codeowners to theme designer v9 (microsoft#27311)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants