Skip to content

Fix wrong state narration for multiple selected legends#27429

Merged
krkshitij merged 4 commits into
microsoft:masterfrom
krkshitij:bug-6763_2
Apr 11, 2023
Merged

Fix wrong state narration for multiple selected legends#27429
krkshitij merged 4 commits into
microsoft:masterfrom
krkshitij:bug-6763_2

Conversation

@krkshitij

@krkshitij krkshitij commented Apr 4, 2023

Copy link
Copy Markdown
Contributor

Previous Behavior

Screen reader announces wrong state information for legends when multiple selection is allowed

New Behavior

Screen reader announces correct state information for legends when multiple selection is allowed

@krkshitij krkshitij marked this pull request as ready for review April 4, 2023 12:28
@krkshitij krkshitij requested a review from a team as a code owner April 4, 2023 12:28
@krkshitij krkshitij requested a review from AtishayMsft April 4, 2023 12:28
@fabricteam

fabricteam commented Apr 4, 2023

Copy link
Copy Markdown
Collaborator

📊 Bundle size report

🤖 This report was generated against 8b3c1619b483d19e4d3a0e4c30b03cb2ab055467

@codesandbox-ci

codesandbox-ci Bot commented Apr 4, 2023

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 43e3b84:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor

size-auditor Bot commented Apr 4, 2023

Copy link
Copy Markdown

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 8b3c1619b483d19e4d3a0e4c30b03cb2ab055467 (build)

Comment thread packages/react-charting/src/components/Legends/Legends.base.tsx Outdated
@krkshitij krkshitij requested a review from AtishayMsft April 11, 2023 11:29
Comment thread packages/react-charting/src/components/Legends/Legends.base.tsx
@krkshitij krkshitij requested a review from AtishayMsft April 11, 2023 16:19
@krkshitij krkshitij merged commit 055497d into microsoft:master Apr 11, 2023
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Apr 13, 2023
…t/drawer-light-dismiss-prop

* marcosmoura/feat/drawer-component: (51 commits)
  fix: upgrade react-dialog
  Doc: Add/Remove TreeItem and useFlatTree stories (microsoft#27515)
  applying package updates
  Fix accessibility labels for tree stories (microsoft#27443)
  fix: BasePickerListBelow aria-describedby with values (microsoft#27525)
  chore: Remove deprecated InputField, etc. shim components (microsoft#27492)
  [Feature]: allow aria-description attribute on v9 (microsoft#27478)
  feat(react-jsx-runtime): implements custom JSX pragma (microsoft#27472)
  chore: update generator to include "test-ssr" script (microsoft#27463)
  applying package updates
  fix: add "style" to exports field (microsoft#27274)
  applying package updates
  feat(react-datepicker-compat): Make package public (microsoft#27524)
  fix: react-combobox defines fallbackPositions for popup on small screens (microsoft#27521)
  fix: use tabster to focus on trigger, instead of manually invoking .focus (microsoft#27512)
  add cxe-red to react-shared-context ownership (microsoft#27296)
  docs: add props tables for all exported Popover controls (microsoft#27503)
  fix: Update FormFieldShim to work with Field context changes (microsoft#27436)
  Fix wrong state narration for multiple selected legends (microsoft#27429)
  add codeowners to theme designer v9 (microsoft#27311)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants