📊 Bundle size report

_{🤖 This report was generated against 4f76849de438f2ee7842121ac3b8176ba1c0a2a5}

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7fc2f47:

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 4f76849de438f2ee7842121ac3b8176ba1c0a2a5 (build)

Based on a discussion yesterday: the approach with slot() function will be a breaking change for consumers that use composition and rely on custom render templates that are using getSlots().

@bsunderhus I prototyped a less breaking change that allows us to keep existing code or to do gradual changes: https://codesandbox.io/s/wispy-leftpad-f8yi37?file=/example.tsx.

Key changes compared to current implementation:

• resolveShorthand stores defaultProps.children, it's a single thing that we need to store to make it working
• getSlots() does not handle typeof children === 'function', it will be handled by JSX pragma
• JSX pragma is a thin wrapper that handles a case with function

That solution passing cases in this example. Key benefit is that we don't change other internals and don't need to apply changes to other hooks. The next step could be moving functionality of getSlots() to JSX pragma.

@bsunderhus I prototyped a less breaking change that allows us to keep existing code or to do gradual changes: https://codesandbox.io/s/wispy-leftpad-f8yi37?file=/example.tsx.

Key changes compared to current implementation:

• resolveShorthand stores defaultProps.children, it's a single thing that we need to store to make it working
• getSlots() does not handle typeof children === 'function', it will be handled by JSX pragma
• JSX pragma is a thin wrapper that handles a case with function

That solution passing cases in this example. Key benefit is that we don't change other internals and don't need to apply changes to other hooks. The next step could be moving functionality of getSlots() to JSX pragma.

I'll see to add it as an option on the RFC! Thx for the contribution @layershifter!

Based on a discussion yesterday: the approach with slot() function will be a breaking change for consumers that use composition and rely on custom render templates that are using getSlots().

Honestly, why do we have _unstable suffix if we're not allowed to change internals signature for cases that would clearly improve internals?

@layershifter @bsunderhus let's ask WISE (a.k.a @jspurlin) for their thoughts on this, they are a partner that have fully invested in composition

@bsunderhus As RFC is quite big, would you mind to run doctoc to generate table of contents in it? 🙏