fix: SplitButton should display correctly in high contrast mode#27137
Merged
Conversation
Added the following changes so that SplitButton would display correctly in windows high contrast mode: * Applied transparent border in top level theme for primary split buttons * Applied transparent border in top level theme for disabled split buttons * Created a new data-url for the toggle indicator in forced colours theme * Add explicit system colour for the divider in forced colours theme Before After
Collaborator
📊 Bundle size report🤖 This report was generated against ddf9297f706ef97d6e41ab9548547b7725190a73 |
jurokapsiar
approved these changes
Mar 9, 2023
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: ddf9297f706ef97d6e41ab9548547b7725190a73 (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1ab967b:
|
Collaborator
Perf Analysis (
|
Collaborator
🕵 FluentUI-v0 No visual regressions between this PR and main |
GeoffCoxMSFT
pushed a commit
to GeoffCoxMSFT/fluentui
that referenced
this pull request
Mar 14, 2023
…osoft#27137) * fix: SplitButton should display correctly in high contrast mode Added the following changes so that SplitButton would display correctly in windows high contrast mode: * Applied transparent border in top level theme for primary split buttons * Applied transparent border in top level theme for disabled split buttons * Created a new data-url for the toggle indicator in forced colours theme * Add explicit system colour for the divider in forced colours theme Before After * changelog * revert changes in main theme
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the following changes so that SplitButton would display correctly in windows high contrast mode:
Previous Behavior
New Behavior
Fixes #27123