chore: migrate to jest 27#26835
Merged
Merged
Conversation
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: d858041352851ffdeb5ac8d51e18cd44b46414ab (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit bac018b:
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1384 | 1295 | 5000 | |
| Button | mount | 938 | 967 | 5000 | |
| Field | mount | 2096 | 2052 | 5000 | |
| FluentProvider | mount | 1664 | 1596 | 5000 | |
| FluentProviderWithTheme | mount | 644 | 641 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 587 | 600 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 633 | 625 | 10 | |
| InfoButton | mount | 566 | 589 | 5000 | |
| MakeStyles | mount | 1943 | 1891 | 50000 | |
| Persona | mount | 3064 | 3046 | 5000 | |
| SpinButton | mount | 2538 | 2486 | 5000 |
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Collaborator
Perf Analysis (
|
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
Hotell
force-pushed
the
hotell/jest/27
branch
from
3d80e23 to
3d3424c
Compare
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 1189 | 1173 | 5000 | |
| Breadcrumb | mount | 2966 | 2975 | 1000 | |
| Checkbox | mount | 2638 | 2644 | 5000 | |
| CheckboxBase | mount | 2375 | 2347 | 5000 | |
| ChoiceGroup | mount | 4433 | 4441 | 5000 | |
| ComboBox | mount | 1258 | 1272 | 1000 | |
| CommandBar | mount | 9653 | 9664 | 1000 | |
| ContextualMenu | mount | 14871 | 15199 | 1000 | |
| DefaultButton | mount | 1376 | 1368 | 5000 | |
| DetailsRow | mount | 3507 | 3401 | 5000 | |
| DetailsRowFast | mount | 3430 | 3446 | 5000 | |
| DetailsRowNoStyles | mount | 3299 | 3328 | 5000 | |
| Dialog | mount | 3068 | 3088 | 1000 | |
| DocumentCardTitle | mount | 593 | 590 | 1000 | |
| Dropdown | mount | 3218 | 3209 | 5000 | |
| FocusTrapZone | mount | 2002 | 2006 | 5000 | |
| FocusZone | mount | 1959 | 1967 | 5000 | |
| GroupedList | mount | 53477 | 59859 | 2 | |
| GroupedList | virtual-rerender | 24771 | 24895 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 91602 | 92199 | 2 | |
| GroupedListV2 | mount | 571 | 553 | 2 | |
| GroupedListV2 | virtual-rerender | 557 | 551 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 574 | 570 | 2 | |
| IconButton | mount | 1901 | 1919 | 5000 | |
| Label | mount | 739 | 740 | 5000 | |
| Layer | mount | 4334 | 4385 | 5000 | |
| Link | mount | 828 | 842 | 5000 | |
| MenuButton | mount | 1689 | 1678 | 5000 | |
| MessageBar | mount | 2333 | 2307 | 5000 | |
| Nav | mount | 3256 | 3258 | 1000 | |
| OverflowSet | mount | 1349 | 1375 | 5000 | |
| Panel | mount | 2564 | 2571 | 1000 | |
| Persona | mount | 1313 | 1327 | 1000 | |
| Pivot | mount | 1651 | 1632 | 1000 | |
| PrimaryButton | mount | 1530 | 1520 | 5000 | |
| Rating | mount | 7019 | 7044 | 5000 | |
| SearchBox | mount | 1507 | 1533 | 5000 | |
| Shimmer | mount | 2881 | 2910 | 5000 | |
| Slider | mount | 2131 | 2115 | 5000 | |
| SpinButton | mount | 4692 | 4762 | 5000 | |
| Spinner | mount | 816 | 800 | 5000 | |
| SplitButton | mount | 3118 | 3129 | 5000 | |
| Stack | mount | 830 | 848 | 5000 | |
| StackWithIntrinsicChildren | mount | 2322 | 2355 | 5000 | |
| StackWithTextChildren | mount | 4764 | 4815 | 5000 | |
| SwatchColorPicker | mount | 10536 | 10387 | 5000 | |
| TagPicker | mount | 2694 | 2613 | 5000 | |
| TeachingBubble | mount | 95621 | 95093 | 5000 | |
| Text | mount | 784 | 784 | 5000 | |
| TextField | mount | 1606 | 1552 | 5000 | |
| ThemeProvider | mount | 1515 | 1517 | 5000 | |
| ThemeProvider | virtual-rerender | 1070 | 1073 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 2156 | 2164 | 5000 | |
| Toggle | mount | 1112 | 1115 | 5000 | |
| buttonNative | mount | 537 | 541 | 5000 |
Collaborator
🕵 FluentUI-v0 No visual regressions between this PR and main |
Hotell
force-pushed
the
hotell/jest/27
branch
from
b49515b to
413eb3d
Compare
Hotell
force-pushed
the
hotell/jest/27
branch
4 times, most recently
from
b6b2487 to
e622693
Compare
fabricteam
reviewed
Feb 20, 2023
Hotell
force-pushed
the
hotell/jest/27
branch
from
c3cedca to
6151e19
Compare
Hotell
commented
Feb 21, 2023
3 tasks
layershifter
approved these changes
Feb 23, 2023
micahgodbolt
approved these changes
Feb 23, 2023
khmakoto
approved these changes
Feb 23, 2023
Hotell
force-pushed
the
hotell/jest/27
branch
from
6151e19 to
bac018b
Compare
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Feb 24, 2023
* master: (93 commits) chore: migrate to jest 27 (microsoft#26835) chore: make lint task run without need of build (microsoft#26872) chore(react-table): exports UseTableSelectionOptions (microsoft#26892) applying package updates fix(react-card): allow elements to grow to fill the available space (microsoft#26616) fix: Popover without focus trap should not be aria-hidden (microsoft#26932) applying package updates applying package updates fix(react-combobox): Remove _getAriaActiveDescendantValue, compute aria-activedescendantvalue in state, and update currentPendingValue when the options change (microsoft#26574) fix: v8 Combobox role and accname for non-hidden icon button (microsoft#26905) fix: Removing possible recursive loop in Coachmark (microsoft#26934) Combobox: Fix cursor jumping to the end of input (microsoft#26931) Fix missing icons on website (microsoft#26797) fix: Fix the width of Input's focus border with appearance=underline (microsoft#26881) chore: Clean up Input's interactive styles (microsoft#26865) Remove codeowners from change files (microsoft#26935) chore: add splitbutton error warning to docs, remove button ariaDescription example (microsoft#26904) docs: Remove testing code from MenuList example (microsoft#26929) chore: refactor SpinButton to use makeResetStyles (microsoft#26867) feat: Set overflow on positioned element when `autosize` is applied (microsoft#26868) ...
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Mar 15, 2023
…r-component * feat/drawer-base-component: (141 commits) remove DrawerContainer feat: WIP add initial draft for Drawer and DrawerContainer chore: migrate to jest 27 (microsoft#26835) chore: make lint task run without need of build (microsoft#26872) chore(react-table): exports UseTableSelectionOptions (microsoft#26892) applying package updates fix(react-card): allow elements to grow to fill the available space (microsoft#26616) fix: Popover without focus trap should not be aria-hidden (microsoft#26932) applying package updates applying package updates fix(react-combobox): Remove _getAriaActiveDescendantValue, compute aria-activedescendantvalue in state, and update currentPendingValue when the options change (microsoft#26574) fix: v8 Combobox role and accname for non-hidden icon button (microsoft#26905) fix: Removing possible recursive loop in Coachmark (microsoft#26934) Combobox: Fix cursor jumping to the end of input (microsoft#26931) Fix missing icons on website (microsoft#26797) fix: Fix the width of Input's focus border with appearance=underline (microsoft#26881) chore: Clean up Input's interactive styles (microsoft#26865) Remove codeowners from change files (microsoft#26935) chore: add splitbutton error warning to docs, remove button ariaDescription example (microsoft#26904) docs: Remove testing code from MenuList example (microsoft#26929) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Behavior
jest 27
modernmode by defaultjsdomis not set as default anymore. This PR's sets every project testEnvironment tojsdomto make things work. There can be more perf optimizations wins with further configuration setup on package/test basis ( using jsdom adds huge overhead for jest test speeds )ts-jest 27
Issues
legacyfake timers wont make them pass 3d80e23Related Issue(s)