chore(react-menu): removes prop spreading on MenuList state#25672
Merged
bsunderhus merged 2 commits intoDec 5, 2022
Merged
Conversation
bsunderhus
force-pushed
the
react-menu/chore--stop-prop-spreading-on-state
branch
from
a3daf61 to
bff7b96
Compare
Collaborator
📊 Bundle size report
Unchanged fixtures
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1557 | 1530 | 5000 | |
| Button | mount | 1038 | 1060 | 5000 | |
| FluentProvider | mount | 1775 | 1770 | 5000 | |
| FluentProviderWithTheme | mount | 653 | 655 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 612 | 602 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 646 | 655 | 10 | |
| MakeStyles | mount | 2062 | 2095 | 50000 | |
| SpinButton | mount | 3026 | 3019 | 5000 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 71139fbfe025c22f9934738ab53d14b5f62e4d66 (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5f5cb25:
|
bsunderhus
force-pushed
the
react-menu/chore--stop-prop-spreading-on-state
branch
from
e37dd71 to
5f5cb25
Compare
ling1726
approved these changes
Nov 28, 2022
ling1726
added a commit
to ling1726/fluentui
that referenced
this pull request
Jan 9, 2023
Fixes the regression introduced in microsoft#25672 so that prop values win over context props with the same name. Fixes #
This was referenced Jan 9, 2023
ling1726
added a commit
that referenced
this pull request
Jan 9, 2023
* fix: MenuList props should win over context props Fixes the regression introduced in #25672 so that prop values win over context props with the same name. Fixes # * changefile
q1b
pushed a commit
to q1b/fluentui
that referenced
this pull request
Jan 24, 2023
* fix: MenuList props should win over context props Fixes the regression introduced in microsoft#25672 so that prop values win over context props with the same name. Fixes # * changefile
Hotell
pushed a commit
to Hotell/fluentui
that referenced
this pull request
Feb 9, 2023
…t#25672) * chore(react-menu): removes prop spreading on MenuList state * chore: deprecates unused type UninitializedMenuListState
Hotell
pushed a commit
to Hotell/fluentui
that referenced
this pull request
Feb 9, 2023
* fix: MenuList props should win over context props Fixes the regression introduced in microsoft#25672 so that prop values win over context props with the same name. Fixes # * changefile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main changes
propsintoMenuListstate declaration.UninitializedMenuListStateThis PR is a code maintenance
Together with type casting, spreading props at state is not ideal as it obscures what properties are actually required to maintain the proper usage of internal state, therefore spreading props at state should be avoided.