Skip to content

chore(vr-tests-v9): Convert Card VR tests to CSF#25526

Merged
TristanWatanabe merged 6 commits into
microsoft:masterfrom
TristanWatanabe:card-to-csf
Nov 16, 2022
Merged

chore(vr-tests-v9): Convert Card VR tests to CSF#25526
TristanWatanabe merged 6 commits into
microsoft:masterfrom
TristanWatanabe:card-to-csf

Conversation

@TristanWatanabe

@TristanWatanabe TristanWatanabe commented Nov 4, 2022

Copy link
Copy Markdown
Member

Changes:

  • uses storybook codemod script convert storiesOf stories to CSF:
    npx sb migrate storiesof-to-csf --glob="apps/vr-tests-react-components/src/stories/{ComponentName}/*.stories.tsx"
  • manually adds RTL, Dark Mode and High Contrast story variants via the getStoryVariant function.

Follows pattern set in #25108.

Related Issue(s)

Part of #25078

@TristanWatanabe TristanWatanabe requested a review from a team as a code owner November 4, 2022 04:28
@TristanWatanabe TristanWatanabe self-assigned this Nov 4, 2022
@github-actions github-actions Bot added this to the October Project Cycle Q4 2022 milestone Nov 4, 2022
@fabricteam

fabricteam commented Nov 4, 2022

Copy link
Copy Markdown
Collaborator

📊 Bundle size report

🤖 This report was generated against e22929a533e0830fc75e547b733b38dee60af00e

@size-auditor

size-auditor Bot commented Nov 4, 2022

Copy link
Copy Markdown

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 38cbc51623baf411e5379936c050f0b2c53ecc54 (build)

@codesandbox-ci

codesandbox-ci Bot commented Nov 4, 2022

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2e9d455:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@TristanWatanabe TristanWatanabe requested a review from a team November 4, 2022 16:07
@TristanWatanabe

Copy link
Copy Markdown
Member Author

Screener change seems to be a minor crop issue caused by the usage of the withFluentProvider addon which can probably be ignored

@marcosmoura marcosmoura self-requested a review November 10, 2022 13:38
@TristanWatanabe TristanWatanabe merged commit f72f978 into microsoft:master Nov 16, 2022
@TristanWatanabe TristanWatanabe deleted the card-to-csf branch November 16, 2022 20:31
NotWoods pushed a commit to NotWoods/fluentui that referenced this pull request Nov 18, 2022
* chore: convert card stories to csf

* nit: remove unused import

* convert CardSelectable stories to CSF

* fix asset url

* fix: delete old story file

* Add side margins to Appearance stories
Hotell pushed a commit to Hotell/fluentui that referenced this pull request Feb 9, 2023
* chore: convert card stories to csf

* nit: remove unused import

* convert CardSelectable stories to CSF

* fix asset url

* fix: delete old story file

* Add side margins to Appearance stories
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants