Skip to content

chore(react-badge): migrate to new package structure#25335

Merged
TristanWatanabe merged 5 commits into
microsoft:masterfrom
TristanWatanabe:migrate-badge
Oct 21, 2022
Merged

chore(react-badge): migrate to new package structure#25335
TristanWatanabe merged 5 commits into
microsoft:masterfrom
TristanWatanabe:migrate-badge

Conversation

@TristanWatanabe

Copy link
Copy Markdown
Member

Changes:

Issue:

@TristanWatanabe TristanWatanabe self-assigned this Oct 21, 2022
@fabricteam

fabricteam commented Oct 21, 2022

Copy link
Copy Markdown
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-alert
Alert
84.688 kB
21.233 kB
react-avatar
Avatar
48.874 kB
13.864 kB
react-avatar
AvatarGroup
14.996 kB
6.013 kB
react-avatar
AvatarGroupItem
68.842 kB
19.205 kB
react-badge
Badge
22.646 kB
7.228 kB
react-badge
CounterBadge
23.536 kB
7.512 kB
react-badge
PresenceBadge
24.096 kB
7.09 kB
react-components
react-components: Button, FluentProvider & webLightTheme
62.94 kB
17.663 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
189.603 kB
52.909 kB
react-components
react-components: FluentProvider & webLightTheme
33.446 kB
11.033 kB
react-persona
Persona
53.992 kB
15.25 kB
react-portal-compat
PortalCompatProvider
5.857 kB
1.978 kB
🤖 This report was generated against 2cf6f6338447c0e81dd06763e4791972a34b0548

@fabricteam

fabricteam commented Oct 21, 2022

Copy link
Copy Markdown
Collaborator

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
SpinButton mount 2533 3375 5000 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1310 1339 5000
Button mount 959 950 5000
FluentProvider mount 1579 1630 5000
FluentProviderWithTheme mount 630 640 10
FluentProviderWithTheme virtual-rerender 593 598 10
FluentProviderWithTheme virtual-rerender-with-unmount 630 626 10
MakeStyles mount 1905 1911 50000
SpinButton mount 2533 3375 5000 Possible regression

@size-auditor

size-auditor Bot commented Oct 21, 2022

Copy link
Copy Markdown

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 2cf6f6338447c0e81dd06763e4791972a34b0548 (build)

@codesandbox-ci

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9b192a9:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@TristanWatanabe TristanWatanabe marked this pull request as ready for review October 21, 2022 19:59
@TristanWatanabe TristanWatanabe requested review from a team and behowell as code owners October 21, 2022 19:59
@TristanWatanabe TristanWatanabe merged commit 1420e05 into microsoft:master Oct 21, 2022
@TristanWatanabe TristanWatanabe deleted the migrate-badge branch October 21, 2022 21:28
NotWoods pushed a commit to NotWoods/fluentui that referenced this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants