Skip to content

chore(public-docsite-v9): update getVnextStories function for gradual v9 package migration#25221

Merged
TristanWatanabe merged 2 commits into
microsoft:masterfrom
TristanWatanabe:update-docsite-story-paths
Oct 14, 2022
Merged

chore(public-docsite-v9): update getVnextStories function for gradual v9 package migration#25221
TristanWatanabe merged 2 commits into
microsoft:masterfrom
TristanWatanabe:update-docsite-story-paths

Conversation

@TristanWatanabe

Copy link
Copy Markdown
Member

Changes:

Related issue

Part of #24129

@TristanWatanabe TristanWatanabe requested a review from a team as a code owner October 13, 2022 20:31
@TristanWatanabe TristanWatanabe self-assigned this Oct 13, 2022
@TristanWatanabe TristanWatanabe requested review from a team as code owners October 13, 2022 20:31
@fabricteam

Copy link
Copy Markdown
Collaborator

📊 Bundle size report

🤖 This report was generated against 82650ef8b3d436c039e33f3eb8a658a3d878064f

@codesandbox-ci

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 34b7835:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor

size-auditor Bot commented Oct 13, 2022

Copy link
Copy Markdown

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 82650ef8b3d436c039e33f3eb8a658a3d878064f (build)

@TristanWatanabe TristanWatanabe merged commit 445fd02 into microsoft:master Oct 14, 2022
//TODO: simplify once v9 migration [https://github.com/microsoft/fluentui/issues/24129] is complete.
if (fs.existsSync(`../../packages/react-components/${name}/stories/`)) {
return `../../../packages/react-components/${name}/stories/${storiesGlob}`;
} else {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no else needed

NotWoods pushed a commit to NotWoods/fluentui that referenced this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants