return skipToMain functionality and hide back to top button#24745
Merged
Conversation
sopranopillow
approved these changes
Sep 9, 2022
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 26d8d54:
|
Collaborator
📊 Bundle size report🤖 This report was generated against 9e604a18ef914090301b4d0cd0b602f646f5719c |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 9e604a18ef914090301b4d0cd0b602f646f5719c (build) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I mistakenly changed the skipToMain functionality to affect the 'back to top button', which broke the former and didn't fix the latter.
I returned the skipToMain functionality to how it was (it was not broken), and fixed the display: none selection that we were using to hide the 'back to top' button.
Fixes #24610