Initial spin-button a11y commit#24075
Merged
Merged
Conversation
Keyboard state diagram, and open questions on accessibility interaction and specification highlighted.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit df44603:
|
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 491945715ffc331e66cf0e371e6e8349d9a9499f (build) |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1184 | 1118 | 5000 | |
| Button | mount | 874 | 960 | 5000 | |
| FluentProvider | mount | 1395 | 1412 | 5000 | |
| FluentProviderWithTheme | mount | 557 | 556 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 522 | 605 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 627 | 633 | 10 | |
| MakeStyles | mount | 1836 | 1763 | 50000 | |
| SpinButton | mount | 2306 | 2278 | 5000 |
spmonahan
reviewed
Jul 26, 2022
smhigley
reviewed
Jul 26, 2022
smhigley
left a comment
smhigley
left a comment
Contributor
There was a problem hiding this comment.
I left a bunch of comments, though not all of them need to be addressed in this PR -- we can add future PRs with more specifics to flesh out sections.
| #### Child content restrictions | ||
|
|
||
| The following child content is allowed: | ||
| 1. Text |
Contributor
There was a problem hiding this comment.
I believe we actually do not allow any children, since the primary slot is an <input> element.
We could mention that the up/down buttons can have children, though.
Contributor
Author
There was a problem hiding this comment.
Other than carats, what other children are allowed?
Contributor
There was a problem hiding this comment.
Other than carats, what other children are allowed?
Technically, anything that can be a child of a <button>. In practice it should probably be restricted to a 16px icon from @fluentui/react-icons as other content will likely break the visual design.
…ton/SpinButtonAccessibility.md Co-authored-by: Sarah Higley <[email protected]>
…ton/index.stories.tsx Co-authored-by: Sarah Higley <[email protected]>
Addressing initial feedback.
Adding note about spinning animation on multiple value changes
spmonahan
reviewed
Aug 5, 2022
Co-authored-by: Sean Monahan <[email protected]>
Replace placeholders for known issues and required props
spmonahan
approved these changes
Aug 17, 2022
spmonahan
left a comment
spmonahan
left a comment
Contributor
There was a problem hiding this comment.
Looks good! Just a few wording suggestions.
…ton/SpinButtonAccessibility.md Co-authored-by: Sean Monahan <[email protected]>
…ton/SpinButtonAccessibility.md Co-authored-by: Sean Monahan <[email protected]>
spmonahan
approved these changes
Aug 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keyboard state diagram, and open questions on accessibility interaction and specification highlighted.