Skip to content

docs(react-card): add information to README file#23888

Merged
theerebuss merged 6 commits into
microsoft:masterfrom
theerebuss:card-readme
Jul 15, 2022
Merged

docs(react-card): add information to README file#23888
theerebuss merged 6 commits into
microsoft:masterfrom
theerebuss:card-readme

Conversation

@theerebuss

@theerebuss theerebuss commented Jul 13, 2022

Copy link
Copy Markdown
Contributor

Current Behavior

Card's README file is very incomplete.

New Behavior

Added:

  • Usage scenario
  • Screenshot of the example
  • Pointer to Spec, API docs and placeholder for migration guide

Related Issue(s)

#19336

@codesandbox-ci

codesandbox-ci Bot commented Jul 13, 2022

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a1950ca:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam

fabricteam commented Jul 13, 2022

Copy link
Copy Markdown
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-card
Card - All
66.431 kB
19.01 kB
react-card
Card
62.113 kB
17.911 kB
react-card
CardFooter
8.461 kB
3.555 kB
react-card
CardHeader
9.504 kB
3.896 kB
react-card
CardPreview
8.562 kB
3.61 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
189.057 kB
52.092 kB
react-components
react-components: FluentProvider & webLightTheme
31.883 kB
10.516 kB
🤖 This report was generated against fa5de11bf3c34c8f195580734eaf0fc829cc1996

@fabricteam

fabricteam commented Jul 13, 2022

Copy link
Copy Markdown
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1549 1545 5000
Button mount 1013 1021 5000
FluentProvider mount 2103 2094 5000
FluentProviderWithTheme mount 652 668 10
FluentProviderWithTheme virtual-rerender 607 611 10
FluentProviderWithTheme virtual-rerender-with-unmount 682 661 10
MakeStyles mount 2181 2155 50000
SpinButton mount 3190 3179 5000

@size-auditor

size-auditor Bot commented Jul 13, 2022

Copy link
Copy Markdown

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: fa5de11bf3c34c8f195580734eaf0fc829cc1996 (build)

Comment thread packages/react-components/react-card/README.md
@theerebuss theerebuss mentioned this pull request Jul 14, 2022
37 tasks
@tudorpopams tudorpopams requested a review from Hotell July 14, 2022 12:19
Comment thread packages/react-components/react-card/README.md Outdated
Comment thread packages/react-components/react-card/README.md Outdated
@theerebuss

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 3 pipeline(s).

@khmakoto khmakoto closed this Jul 15, 2022
@khmakoto khmakoto reopened this Jul 15, 2022
@theerebuss theerebuss merged commit 447b211 into microsoft:master Jul 15, 2022
@theerebuss theerebuss deleted the card-readme branch July 15, 2022 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants