docs(react-avatar): Adding readme and migration guide for AvatarGroup#23758
Conversation
sopranopillow
added
Fluent UI react-components (v9)
Component: Avatar
Component: AvatarGroup
sopranopillow
requested review from
a team,
behowell and
khmakoto
as code owners
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8a8ec3e:
|
📊 Bundle size reportUnchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 2765b1f72c50c96e7f8e433d80762e9fa25d685f (build) |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| MakeStyles | mount | 2458 | 2504 | 50000 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1665 | 1705 | 5000 | |
| Button | mount | 1262 | 1221 | 5000 | |
| FluentProvider | mount | 2299 | 2314 | 5000 | |
| FluentProviderWithTheme | mount | 898 | 912 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 831 | 815 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 912 | 895 | 10 | |
| MakeStyles | mount | 2458 | 2504 | 50000 | Possible regression |
khmakoto
left a comment
khmakoto
left a comment
There was a problem hiding this comment.
I think this is ok for now, once we move the component to stable we should look at having a singular README for both Avatar and AvatarGroup in the react-avatar package root that points to the specs and migration guides of each (which by then should be probably moved to their respective component folders).
Can you make an issue tracking this follow-up work?
Yes, that will be the next step once it's moved to stable. I'll add it to the epic to keep track of it. |
…ect-amout-of-items * master: chore: improve error message in useIsSSR() (microsoft#23750) fix: Codesandbox exports should use ^9.0.0 (microsoft#23764) applying package updates Update BadgeColor.stories.tsx (microsoft#23762) chore(react-avatar): Adding unit and vr tests for AvatarGroup (microsoft#23549) docs(react-avatar): Adding readme and migration guide for AvatarGroup (microsoft#23758) update deps after 9.0.1 release (microsoft#23756) applying package updates fix: Use caret dependency range for Griffel (microsoft#23754) Theme designer: minor fixes (microsoft#23741) fix: Dependency mismatch after 9.0.0 release (microsoft#23752)
…microsoft#23758) * docs: Adding docs for AvatarGroup. * change fileS
3 participants
This PR adds a readme and migration guide for AvatarGroup.
Related Issue(s)
#22240