fix: Use caret dependency range for Griffel#23754
Merged
ling1726 merged 7 commits intoJun 28, 2022
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit cc06e4e:
|
ling1726
requested review from
a team,
GeoffCoxMSFT,
behowell,
chpalac,
khmakoto,
micahgodbolt,
smhigley,
sopranopillow,
spmonahan and
tomi-msft
as code owners
Collaborator
📊 Bundle size reportUnchanged fixtures
|
layershifter
approved these changes
Jun 28, 2022
spmonahan
approved these changes
Jun 28, 2022
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1361 | 1400 | 5000 | |
| Button | mount | 1027 | 1039 | 5000 | |
| FluentProvider | mount | 1885 | 1892 | 5000 | |
| FluentProviderWithTheme | mount | 700 | 742 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 709 | 710 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 715 | 726 | 10 | |
| MakeStyles | mount | 2056 | 2015 | 50000 |
khmakoto
approved these changes
Jun 28, 2022
tudorpopams
approved these changes
Jun 28, 2022
micahgodbolt
approved these changes
Jun 28, 2022
TristanWatanabe
approved these changes
Jun 28, 2022
Collaborator
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| TreeWith60ListItems.default | 152 | 139 | 1.09:1 |
| ButtonMinimalPerf.default | 141 | 131 | 1.08:1 |
| SegmentMinimalPerf.default | 299 | 278 | 1.08:1 |
| ChatDuplicateMessagesPerf.default | 249 | 235 | 1.06:1 |
| ListCommonPerf.default | 528 | 505 | 1.05:1 |
| ListMinimalPerf.default | 445 | 422 | 1.05:1 |
| ListWith60ListItems.default | 517 | 494 | 1.05:1 |
| AlertMinimalPerf.default | 226 | 217 | 1.04:1 |
| AnimationMinimalPerf.default | 473 | 457 | 1.04:1 |
| AttachmentSlotsPerf.default | 952 | 917 | 1.04:1 |
| GridMinimalPerf.default | 281 | 271 | 1.04:1 |
| ListNestedPerf.default | 476 | 459 | 1.04:1 |
| ProviderMinimalPerf.default | 344 | 330 | 1.04:1 |
| ChatWithPopoverPerf.default | 330 | 320 | 1.03:1 |
| HeaderMinimalPerf.default | 300 | 292 | 1.03:1 |
| LabelMinimalPerf.default | 322 | 313 | 1.03:1 |
| PortalMinimalPerf.default | 148 | 144 | 1.03:1 |
| TextMinimalPerf.default | 281 | 274 | 1.03:1 |
| TextAreaMinimalPerf.default | 414 | 401 | 1.03:1 |
| AttachmentMinimalPerf.default | 125 | 123 | 1.02:1 |
| ButtonOverridesMissPerf.default | 1278 | 1252 | 1.02:1 |
| CarouselMinimalPerf.default | 397 | 391 | 1.02:1 |
| DialogMinimalPerf.default | 648 | 633 | 1.02:1 |
| FlexMinimalPerf.default | 239 | 235 | 1.02:1 |
| ImageMinimalPerf.default | 321 | 314 | 1.02:1 |
| LayoutMinimalPerf.default | 296 | 289 | 1.02:1 |
| LoaderMinimalPerf.default | 588 | 576 | 1.02:1 |
| MenuMinimalPerf.default | 725 | 711 | 1.02:1 |
| PopupMinimalPerf.default | 530 | 520 | 1.02:1 |
| RefMinimalPerf.default | 201 | 197 | 1.02:1 |
| SkeletonMinimalPerf.default | 291 | 284 | 1.02:1 |
| ToolbarMinimalPerf.default | 804 | 786 | 1.02:1 |
| VideoMinimalPerf.default | 556 | 547 | 1.02:1 |
| AvatarMinimalPerf.default | 157 | 156 | 1.01:1 |
| ButtonSlotsPerf.default | 459 | 453 | 1.01:1 |
| CardMinimalPerf.default | 466 | 463 | 1.01:1 |
| CheckboxMinimalPerf.default | 2276 | 2243 | 1.01:1 |
| InputMinimalPerf.default | 1107 | 1096 | 1.01:1 |
| MenuButtonMinimalPerf.default | 1457 | 1439 | 1.01:1 |
| ProviderMergeThemesPerf.default | 1066 | 1056 | 1.01:1 |
| RadioGroupMinimalPerf.default | 368 | 366 | 1.01:1 |
| ReactionMinimalPerf.default | 308 | 305 | 1.01:1 |
| SliderMinimalPerf.default | 1427 | 1418 | 1.01:1 |
| SplitButtonMinimalPerf.default | 3732 | 3698 | 1.01:1 |
| TableMinimalPerf.default | 340 | 336 | 1.01:1 |
| CustomToolbarPrototype.default | 2318 | 2302 | 1.01:1 |
| TreeMinimalPerf.default | 685 | 675 | 1.01:1 |
| ChatMinimalPerf.default | 611 | 614 | 1:1 |
| DropdownManyItemsPerf.default | 555 | 555 | 1:1 |
| DropdownMinimalPerf.default | 2666 | 2655 | 1:1 |
| RosterPerf.default | 930 | 928 | 1:1 |
| BoxMinimalPerf.default | 274 | 276 | 0.99:1 |
| EmbedMinimalPerf.default | 3434 | 3465 | 0.99:1 |
| ItemLayoutMinimalPerf.default | 987 | 995 | 0.99:1 |
| TableManyItemsPerf.default | 1609 | 1626 | 0.99:1 |
| DividerMinimalPerf.default | 287 | 293 | 0.98:1 |
| IconMinimalPerf.default | 495 | 504 | 0.98:1 |
| TooltipMinimalPerf.default | 946 | 961 | 0.98:1 |
| HeaderSlotsPerf.default | 623 | 640 | 0.97:1 |
| DatepickerMinimalPerf.default | 4825 | 5015 | 0.96:1 |
| StatusMinimalPerf.default | 549 | 570 | 0.96:1 |
| AccordionMinimalPerf.default | 119 | 127 | 0.94:1 |
| FormMinimalPerf.default | 325 | 346 | 0.94:1 |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 794 | 796 | 5000 | |
| Breadcrumb | mount | 2410 | 2455 | 1000 | |
| Checkbox | mount | 1238 | 1300 | 5000 | |
| CheckboxBase | mount | 1074 | 1120 | 5000 | |
| ChoiceGroup | mount | 4046 | 4066 | 5000 | |
| ComboBox | mount | 861 | 844 | 1000 | |
| CommandBar | mount | 9625 | 9438 | 1000 | |
| ContextualMenu | mount | 12251 | 10626 | 1000 | |
| DefaultButton | mount | 975 | 997 | 5000 | |
| DetailsRow | mount | 3368 | 3317 | 5000 | |
| DetailsRowFast | mount | 3303 | 3351 | 5000 | |
| DetailsRowNoStyles | mount | 3193 | 3160 | 5000 | |
| Dialog | mount | 2507 | 2517 | 1000 | |
| DocumentCardTitle | mount | 150 | 181 | 1000 | |
| Dropdown | mount | 2981 | 2962 | 5000 | |
| FocusTrapZone | mount | 1674 | 1627 | 5000 | |
| FocusZone | mount | 1566 | 1588 | 5000 | |
| IconButton | mount | 1529 | 1527 | 5000 | |
| Label | mount | 304 | 312 | 5000 | |
| Layer | mount | 2510 | 2597 | 5000 | |
| Link | mount | 408 | 411 | 5000 | |
| MenuButton | mount | 1282 | 1310 | 5000 | |
| MessageBar | mount | 1816 | 1828 | 5000 | |
| Nav | mount | 2906 | 2872 | 1000 | |
| OverflowSet | mount | 962 | 964 | 5000 | |
| Panel | mount | 1900 | 1954 | 1000 | |
| Persona | mount | 893 | 873 | 1000 | |
| Pivot | mount | 1265 | 1280 | 1000 | |
| PrimaryButton | mount | 1144 | 1717 | 5000 | |
| Rating | mount | 6719 | 6718 | 5000 | |
| SearchBox | mount | 1128 | 1064 | 5000 | |
| Shimmer | mount | 2173 | 2144 | 5000 | |
| Slider | mount | 1640 | 1717 | 5000 | |
| SpinButton | mount | 4445 | 4423 | 5000 | |
| Spinner | mount | 384 | 382 | 5000 | |
| SplitButton | mount | 2770 | 2744 | 5000 | |
| Stack | mount | 459 | 456 | 5000 | |
| StackWithIntrinsicChildren | mount | 1997 | 1984 | 5000 | |
| StackWithTextChildren | mount | 4553 | 5058 | 5000 | |
| SwatchColorPicker | mount | 10255 | 14309 | 5000 | |
| TagPicker | mount | 2429 | 2419 | 5000 | |
| TeachingBubble | mount | 97466 | 97524 | 5000 | |
| Text | mount | 371 | 365 | 5000 | |
| TextField | mount | 1159 | 1228 | 5000 | |
| ThemeProvider | mount | 1031 | 1021 | 5000 | |
| ThemeProvider | virtual-rerender | 557 | 545 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1545 | 1585 | 5000 | |
| Toggle | mount | 703 | 652 | 5000 | |
| buttonNative | mount | 117 | 102 | 5000 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 267e10e8adb913ba4151054d5b805ac1fe513e35 (build) |
| integrity sha512-vXhOcnlsYA/XgiaiPo4Cyp5GeI+CZE2zRVBNLkygemrafKnboLwUh9dLb/qC4YLsQ4DTaYPrvFq4cKujXBhl4w== | ||
|
|
||
| "@griffel/babel-preset@1.3.2", "@griffel/babel-preset@^1.3.2": | ||
| "@griffel/babel-preset@^1.3.2": |
Member
There was a problem hiding this comment.
This went wild, it seems that something was not bumped properly
Contributor
Author
There was a problem hiding this comment.
good catch 👍 I deduped, and now the only version is 1.3.3
rohitpagariya
pushed a commit
to rohitpagariya/fluentui
that referenced
this pull request
Jun 28, 2022
* fix: Use caret dependency range for Griffel * changefile * update yarn.lock * use griffel core 1.4.1 * fix satisfied
marcosmoura
pushed a commit
to marcosmoura/fluentui
that referenced
this pull request
Jun 29, 2022
…ect-amout-of-items * master: chore: improve error message in useIsSSR() (microsoft#23750) fix: Codesandbox exports should use ^9.0.0 (microsoft#23764) applying package updates Update BadgeColor.stories.tsx (microsoft#23762) chore(react-avatar): Adding unit and vr tests for AvatarGroup (microsoft#23549) docs(react-avatar): Adding readme and migration guide for AvatarGroup (microsoft#23758) update deps after 9.0.1 release (microsoft#23756) applying package updates fix: Use caret dependency range for Griffel (microsoft#23754) Theme designer: minor fixes (microsoft#23741) fix: Dependency mismatch after 9.0.0 release (microsoft#23752)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.