adding GlobeIcon & ArrowSyncIcon#23683
Merged
Merged
Conversation
msft-fluent-ui-bot
added
the
Fluent UI react-northstar (v0)
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b478e00:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 118f7ddaac0f7e1f705f5fb93af7722a35a27610 (build) |
Collaborator
📊 Bundle size report🤖 This report was generated against 118f7ddaac0f7e1f705f5fb93af7722a35a27610 |
Collaborator
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| ReactionMinimalPerf.default | 333 | 266 | 1.25:1 |
| RefMinimalPerf.default | 204 | 171 | 1.19:1 |
| BoxMinimalPerf.default | 279 | 238 | 1.17:1 |
| ChatWithPopoverPerf.default | 325 | 278 | 1.17:1 |
| SkeletonMinimalPerf.default | 282 | 242 | 1.17:1 |
| TextMinimalPerf.default | 282 | 241 | 1.17:1 |
| ListMinimalPerf.default | 436 | 377 | 1.16:1 |
| InputMinimalPerf.default | 1193 | 1043 | 1.14:1 |
| LayoutMinimalPerf.default | 294 | 258 | 1.14:1 |
| VideoMinimalPerf.default | 540 | 473 | 1.14:1 |
| CardMinimalPerf.default | 456 | 408 | 1.12:1 |
| ButtonMinimalPerf.default | 152 | 137 | 1.11:1 |
| MenuMinimalPerf.default | 738 | 665 | 1.11:1 |
| IconMinimalPerf.default | 514 | 465 | 1.11:1 |
| ChatMinimalPerf.default | 621 | 563 | 1.1:1 |
| CustomToolbarPrototype.default | 2348 | 2191 | 1.07:1 |
| ItemLayoutMinimalPerf.default | 983 | 927 | 1.06:1 |
| PortalMinimalPerf.default | 151 | 143 | 1.06:1 |
| ListCommonPerf.default | 523 | 499 | 1.05:1 |
| TextAreaMinimalPerf.default | 361 | 345 | 1.05:1 |
| DropdownMinimalPerf.default | 2572 | 2472 | 1.04:1 |
| ToolbarMinimalPerf.default | 742 | 711 | 1.04:1 |
| DialogMinimalPerf.default | 616 | 598 | 1.03:1 |
| DividerMinimalPerf.default | 293 | 285 | 1.03:1 |
| ListWith60ListItems.default | 456 | 443 | 1.03:1 |
| StatusMinimalPerf.default | 537 | 520 | 1.03:1 |
| TableManyItemsPerf.default | 1566 | 1518 | 1.03:1 |
| TreeWith60ListItems.default | 130 | 126 | 1.03:1 |
| ChatDuplicateMessagesPerf.default | 242 | 238 | 1.02:1 |
| FormMinimalPerf.default | 342 | 334 | 1.02:1 |
| RosterPerf.default | 932 | 917 | 1.02:1 |
| TableMinimalPerf.default | 336 | 328 | 1.02:1 |
| TooltipMinimalPerf.default | 933 | 919 | 1.02:1 |
| AlertMinimalPerf.default | 221 | 219 | 1.01:1 |
| ButtonOverridesMissPerf.default | 1270 | 1258 | 1.01:1 |
| CheckboxMinimalPerf.default | 2166 | 2148 | 1.01:1 |
| HeaderSlotsPerf.default | 609 | 600 | 1.01:1 |
| ProviderMinimalPerf.default | 340 | 337 | 1.01:1 |
| SegmentMinimalPerf.default | 247 | 244 | 1.01:1 |
| EmbedMinimalPerf.default | 3340 | 3350 | 1:1 |
| SplitButtonMinimalPerf.default | 3673 | 3681 | 1:1 |
| AnimationMinimalPerf.default | 401 | 405 | 0.99:1 |
| LoaderMinimalPerf.default | 554 | 561 | 0.99:1 |
| MenuButtonMinimalPerf.default | 1397 | 1415 | 0.99:1 |
| AccordionMinimalPerf.default | 121 | 123 | 0.98:1 |
| AttachmentMinimalPerf.default | 119 | 122 | 0.98:1 |
| FlexMinimalPerf.default | 228 | 233 | 0.98:1 |
| GridMinimalPerf.default | 235 | 240 | 0.98:1 |
| TreeMinimalPerf.default | 618 | 637 | 0.97:1 |
| AttachmentSlotsPerf.default | 837 | 871 | 0.96:1 |
| DropdownManyItemsPerf.default | 526 | 548 | 0.96:1 |
| SliderMinimalPerf.default | 1361 | 1421 | 0.96:1 |
| PopupMinimalPerf.default | 507 | 536 | 0.95:1 |
| ProviderMergeThemesPerf.default | 1010 | 1066 | 0.95:1 |
| CarouselMinimalPerf.default | 354 | 378 | 0.94:1 |
| ImageMinimalPerf.default | 279 | 298 | 0.94:1 |
| ButtonSlotsPerf.default | 428 | 460 | 0.93:1 |
| ListNestedPerf.default | 432 | 466 | 0.93:1 |
| AvatarMinimalPerf.default | 143 | 156 | 0.92:1 |
| DatepickerMinimalPerf.default | 4589 | 4964 | 0.92:1 |
| LabelMinimalPerf.default | 280 | 309 | 0.91:1 |
| HeaderMinimalPerf.default | 264 | 299 | 0.88:1 |
| RadioGroupMinimalPerf.default | 326 | 371 | 0.88:1 |
ling1726
reviewed
Jun 27, 2022
ling1726
reviewed
Jun 27, 2022
…on.tsx Co-authored-by: ling1726 <[email protected]>
ling1726
approved these changes
Jun 28, 2022
rohitpagariya
pushed a commit
to rohitpagariya/fluentui
that referenced
this pull request
Jun 28, 2022
* adding GlobeIcon & ArrowSyncIcon * adding changelog * updating icon * Update packages/fluentui/react-icons-northstar/src/components/GlobeIcon.tsx Co-authored-by: ling1726 <[email protected]> * reverting changes to syncicon * adding arrowsync icon * adding arrowsync icon Co-authored-by: ling1726 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding GlobeIcon and adding overflow to SyncIcon
