OverflowSet: minor docs wording update#23587
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 235ce89:
|
📊 Bundle size report🤖 This report was generated against 8d6d8a3e334c1ad298dcae3732ae555b58fe7bf1 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 8d6d8a3e334c1ad298dcae3732ae555b58fe7bf1 (build) |
| ### Accessibility | ||
|
|
||
| By default, the OverflowSet is simply `role=group`. If you used as a menu, you will need to add `role="menubar"` and add proper aria roles to each rendered item (`menuitem`, `menuitemcheckbox`, `menuitemradio`) | ||
| By default, the OverflowSet is simply `role=group`. If you used as an application menu, the `overflowItems` prop on CommandBar should be used instead. When `OverflowSet` is used on its own, any context-specific semantics (e.g. `role="menu"`, `role="nav"`) and interaction (e.g. arrow keys) will need to be manually added. |
There was a problem hiding this comment.
the
overflowItemsprop on CommandBar should be used instead
instead of what?
There was a problem hiding this comment.
ah, instead of using OverflowSet on its own. I'll make that clearer.
micahgodbolt
left a comment
micahgodbolt
left a comment
There was a problem hiding this comment.
This text is great. I'd eventually like to see some demos of how to do this.
5 participants
In a discussion on an OverflowSet, I realized the Accessibility wording was a bit misleading. I updated the wording to both mention CommandBar's overflow feature, and also that keyboard interaction would be needed as well as semantics for e.g. a menu.