feat: Global context shim#23324
Merged
Merged
Conversation
Autogenerated from `yarn create-package`
Adds a shim for `createContext` that will register the context to the global scope, and reuse a globally scoped context if it already exists
Collaborator
📊 Bundle size report
🤖 This report was generated against e303ce6bf879c989f2de9558be581bbfac2ae55f |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 17cf4eb:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: e303ce6bf879c989f2de9558be581bbfac2ae55f (build) |
Hotell
reviewed
May 30, 2022
Member
|
Would you mind to add bundle size fixtures? |
…ixture.js Co-authored-by: Oleksandr Fediashov <[email protected]>
layershifter
approved these changes
May 31, 2022
…textSelector.fixture.js Co-authored-by: Oleksandr Fediashov <[email protected]>
layershifter
reviewed
Jun 1, 2022
| }, | ||
| "dependencies": { | ||
| "@fluentui/react-context-selector": "9.0.0-rc.10", | ||
| "@fluentui/react-theme": "9.0.0-rc.9", |
Member
There was a problem hiding this comment.
Suggested change
| "@fluentui/react-theme": "9.0.0-rc.9", |
Please also remove other unrelated dependencies, too.
Contributor
Author
There was a problem hiding this comment.
ah good catch, I did a bad merge commit
marwan38
pushed a commit
to marwan38/fluentui
that referenced
this pull request
Jun 13, 2022
* chore: bootstrap @fluentui/global-context package Autogenerated from `yarn create-package` * fix codeowners * update md * feat: Global context shim Adds a shim for `createContext` that will register the context to the global scope, and reuse a globally scoped context if it already exists * Add context selector shim and node + browser tests * update md * fix tsdoc * add bundlesize * Update packages/react-components/global-context/bundle-size/Default.fixture.js Co-authored-by: Oleksandr Fediashov <[email protected]> * custom webpack config * Update packages/react-components/global-context/bundle-size/createContextSelector.fixture.js Co-authored-by: Oleksandr Fediashov <[email protected]> * add README * remove react-theme * remove griffel Co-authored-by: Oleksandr Fediashov <[email protected]>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a shim for
createContextthat will register the context to theglobal scope, and reuse a globally scoped context if it already exists