(chore) Move react-portal-compat to react-components subfolder by TristanWatanabe · Pull Request #22829 · microsoft/fluentui

TristanWatanabe · 2022-05-04T14:45:10Z

Changes

Moves @fluentui/react-portal-compat to react-components common folder using move-packages nx generator.

DO NOT MERGE UNTIL ONGOING WORK IS COMPLETE: #22541

Related Issue(s)

Part of #22427

codesandbox-ci · 2022-05-04T14:51:45Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 851e52a:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

fabricteam · 2022-05-04T14:56:39Z

Perf Analysis (`@fluentui/react-components`)

Scenario	Render type	Master Ticks	PR Ticks	Iterations	Status
FluentProviderWithTheme	virtual-rerender-with-unmount	278	320	10	Possible regression

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations	Status
Avatar	mount	904	907	5000
Button	mount	554	547	5000
FluentProvider	mount	1802	1885	5000
FluentProviderWithTheme	mount	296	302	10
FluentProviderWithTheme	virtual-rerender	255	248	10
FluentProviderWithTheme	virtual-rerender-with-unmount	278	320	10	Possible regression
MakeStyles	mount	1558	1576	50000

size-auditor · 2022-05-04T14:56:57Z

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 8437eb3b6023bdac5b234538e1116b1c7d24f53f (build)

fabricteam · 2022-05-04T15:03:09Z

📊 Bundle size report

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`react-accordion` Accordion (including children components)	`73.754 kB` `22.494 kB`
`react-badge` Badge	`20.965 kB` `6.605 kB`
`react-badge` CounterBadge	`21.918 kB` `6.919 kB`
`react-badge` PresenceBadge	`22.005 kB` `6.582 kB`
`react-combobox` Combobox	`60.564 kB` `20.751 kB`
`react-divider` Divider	`15.455 kB` `5.57 kB`
`react-radio` Radio	`29.382 kB` `10.047 kB`
`react-radio` RadioGroup	`13.61 kB` `5.462 kB`
`react-switch` Switch	`25.312 kB` `8.202 kB`
`react-textarea` Textarea	`20.672 kB` `7.07 kB`

_{🤖 This report was generated against 8437eb3b6023bdac5b234538e1116b1c7d24f53f}

fabricteam · 2022-05-04T15:03:47Z

Perf Analysis (`@fluentui/react-northstar`)

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
AttachmentMinimalPerf.default	135	101	1.34:1
ImageMinimalPerf.default	319	264	1.21:1
PortalMinimalPerf.default	147	121	1.21:1
AvatarMinimalPerf.default	164	140	1.17:1
GridMinimalPerf.default	284	245	1.16:1
AnimationMinimalPerf.default	459	400	1.15:1
LayoutMinimalPerf.default	298	259	1.15:1
DividerMinimalPerf.default	296	262	1.13:1
IconMinimalPerf.default	498	439	1.13:1
TextAreaMinimalPerf.default	393	348	1.13:1
TooltipMinimalPerf.default	911	818	1.11:1
ToolbarMinimalPerf.default	808	737	1.1:1
ButtonMinimalPerf.default	150	137	1.09:1
ChatMinimalPerf.default	619	570	1.09:1
ReactionMinimalPerf.default	292	269	1.09:1
SkeletonMinimalPerf.default	278	256	1.09:1
ListWith60ListItems.default	564	520	1.08:1
VideoMinimalPerf.default	558	515	1.08:1
HeaderSlotsPerf.default	626	596	1.05:1
ListNestedPerf.default	424	403	1.05:1
MenuButtonMinimalPerf.default	1438	1372	1.05:1
ButtonOverridesMissPerf.default	1269	1215	1.04:1
ButtonSlotsPerf.default	468	451	1.04:1
TableManyItemsPerf.default	1564	1509	1.04:1
ChatDuplicateMessagesPerf.default	241	235	1.03:1
CheckboxMinimalPerf.default	2286	2218	1.03:1
AccordionMinimalPerf.default	126	123	1.02:1
BoxMinimalPerf.default	280	274	1.02:1
CarouselMinimalPerf.default	403	396	1.02:1
StatusMinimalPerf.default	567	558	1.02:1
TreeMinimalPerf.default	670	655	1.02:1
ChatWithPopoverPerf.default	293	290	1.01:1
FormMinimalPerf.default	335	332	1.01:1
ProviderMinimalPerf.default	334	330	1.01:1
SliderMinimalPerf.default	1376	1363	1.01:1
SplitButtonMinimalPerf.default	3659	3610	1.01:1
HeaderMinimalPerf.default	295	294	1:1
ListCommonPerf.default	523	522	1:1
ListMinimalPerf.default	432	434	1:1
RosterPerf.default	931	935	1:1
TableMinimalPerf.default	333	334	1:1
DatepickerMinimalPerf.default	4761	4799	0.99:1
DialogMinimalPerf.default	636	642	0.99:1
DropdownMinimalPerf.default	2478	2505	0.99:1
LoaderMinimalPerf.default	564	572	0.99:1
RefMinimalPerf.default	191	193	0.99:1
PopupMinimalPerf.default	489	500	0.98:1
CustomToolbarPrototype.default	2181	2232	0.98:1
ProviderMergeThemesPerf.default	1027	1060	0.97:1
AlertMinimalPerf.default	216	224	0.96:1
DropdownManyItemsPerf.default	535	560	0.96:1
EmbedMinimalPerf.default	3308	3449	0.96:1
MenuMinimalPerf.default	680	710	0.96:1
AttachmentSlotsPerf.default	876	919	0.95:1
InputMinimalPerf.default	1039	1094	0.95:1
ItemLayoutMinimalPerf.default	940	988	0.95:1
RadioGroupMinimalPerf.default	351	369	0.95:1
LabelMinimalPerf.default	297	320	0.93:1
SegmentMinimalPerf.default	259	284	0.91:1
CardMinimalPerf.default	409	467	0.88:1
FlexMinimalPerf.default	204	234	0.87:1
TextMinimalPerf.default	248	286	0.87:1
TreeWith60ListItems.default	123	142	0.87:1

fabricteam · 2022-05-04T15:09:19Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
BaseButton	mount	786	771	5000
Breadcrumb	mount	2259	2299	1000
Checkbox	mount	1246	1278	5000
CheckboxBase	mount	1076	1077	5000
ChoiceGroup	mount	3978	3955	5000
ComboBox	mount	800	775	1000
CommandBar	mount	8794	8857	1000
ContextualMenu	mount	9496	9440	1000
DefaultButton	mount	950	952	5000
DetailsRow	mount	3066	3101	5000
DetailsRowFast	mount	3064	3134	5000
DetailsRowNoStyles	mount	2878	2872	5000
Dialog	mount	1874	1856	1000
DocumentCardTitle	mount	162	162	1000
Dropdown	mount	2810	2765	5000
FocusTrapZone	mount	1579	1546	5000
FocusZone	mount	1558	1540	5000
IconButton	mount	1406	1400	5000
Label	mount	329	330	5000
Layer	mount	2561	2555	5000
Link	mount	428	424	5000
MenuButton	mount	1220	1194	5000
MessageBar	mount	1840	1833	5000
Nav	mount	2671	2657	1000
OverflowSet	mount	1009	993	5000
Panel	mount	1820	1803	1000
Persona	mount	858	852	1000
Pivot	mount	1144	1123	1000
PrimaryButton	mount	1097	1093	5000
Rating	mount	6717	6618	5000
SearchBox	mount	1103	1113	5000
Shimmer	mount	2261	2218	5000
Slider	mount	1714	1711	5000
SpinButton	mount	3942	3952	5000
Spinner	mount	399	400	5000
SplitButton	mount	2448	2469	5000
Stack	mount	483	484	5000
StackWithIntrinsicChildren	mount	1845	1860	5000
StackWithTextChildren	mount	4662	4640	5000
SwatchColorPicker	mount	9092	9075	5000
TagPicker	mount	2045	2033	5000
TeachingBubble	mount	74739	73710	5000
Text	mount	388	398	5000
TextField	mount	1154	1175	5000
ThemeProvider	mount	963	950	5000
ThemeProvider	virtual-rerender	607	617	5000
ThemeProvider	virtual-rerender-with-unmount	1423	1464	5000
Toggle	mount	718	706	5000
buttonNative	mount	112	101	5000

…soft#22829) * move react-portal-compat * Change File

TristanWatanabe added 2 commits May 4, 2022 07:38

move react-portal-compat

90c1dd8

Change File

851e52a

msft-fluent-ui-bot assigned GeoffCoxMSFT May 4, 2022

TristanWatanabe assigned TristanWatanabe and unassigned GeoffCoxMSFT May 4, 2022

TristanWatanabe added the Area: Build System label May 4, 2022

TristanWatanabe mentioned this pull request May 4, 2022

group vNext to common folder (as people will start check vNext) #22427

Closed

23 tasks

TristanWatanabe marked this pull request as ready for review May 4, 2022 15:37

TristanWatanabe requested review from a team, JustSlone and jurokapsiar as code owners May 4, 2022 15:37

layershifter approved these changes May 4, 2022

View reviewed changes

ling1726 approved these changes May 4, 2022

View reviewed changes

TristanWatanabe merged commit 4484d11 into microsoft:master May 4, 2022

TristanWatanabe deleted the move-react-portal-compat branch May 4, 2022 18:44

marwan38 pushed a commit to marwan38/fluentui that referenced this pull request Jun 13, 2022

(chore) Move react-portal-compat to react-components subfolder (micro…

83603ab

…soft#22829) * move react-portal-compat * Change File

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

(chore) Move react-portal-compat to react-components subfolder#22829

(chore) Move react-portal-compat to react-components subfolder#22829
TristanWatanabe merged 2 commits into
microsoft:masterfrom
TristanWatanabe:move-react-portal-compat

TristanWatanabe commented May 4, 2022 •

edited

Loading

Uh oh!

codesandbox-ci Bot commented May 4, 2022

Uh oh!

fabricteam commented May 4, 2022

Uh oh!

size-auditor Bot commented May 4, 2022

Uh oh!

fabricteam commented May 4, 2022

Uh oh!

fabricteam commented May 4, 2022

Uh oh!

fabricteam commented May 4, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

TristanWatanabe commented May 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Related Issue(s)

Uh oh!

codesandbox-ci Bot commented May 4, 2022

Uh oh!

fabricteam commented May 4, 2022

Perf Analysis (@fluentui/react-components)

Uh oh!

size-auditor Bot commented May 4, 2022

Asset size changes

Uh oh!

fabricteam commented May 4, 2022

📊 Bundle size report

Uh oh!

fabricteam commented May 4, 2022

Perf Analysis (@fluentui/react-northstar)

Uh oh!

fabricteam commented May 4, 2022

Perf Analysis (@fluentui/react)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

TristanWatanabe commented May 4, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react-components`)

Perf Analysis (`@fluentui/react-northstar`)

Perf Analysis (`@fluentui/react`)