(chore) Move react-accordion, react-divider to react-components subfolder #22827
Merged
TristanWatanabe merged 14 commits intoMay 18, 2022
Merged
Conversation
23 tasks
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e6eb958:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 8ab3a2ac23ee12d9b5fbd72d3b4593fb3691209b (build) |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1025 | 1101 | 5000 | |
| Button | mount | 656 | 654 | 5000 | |
| FluentProvider | mount | 2195 | 2187 | 5000 | |
| FluentProviderWithTheme | mount | 343 | 318 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 298 | 286 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 395 | 399 | 10 | |
| MakeStyles | mount | 1818 | 1814 | 50000 |
Collaborator
📊 Bundle size report
Unchanged fixtures
|
Collaborator
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| AccordionMinimalPerf.default | 169 | 154 | 1.1:1 |
| RefMinimalPerf.default | 254 | 234 | 1.09:1 |
| SegmentMinimalPerf.default | 399 | 370 | 1.08:1 |
| ListWith60ListItems.default | 747 | 699 | 1.07:1 |
| CardMinimalPerf.default | 657 | 622 | 1.06:1 |
| LayoutMinimalPerf.default | 417 | 395 | 1.06:1 |
| ReactionMinimalPerf.default | 428 | 405 | 1.06:1 |
| AttachmentMinimalPerf.default | 175 | 166 | 1.05:1 |
| GridMinimalPerf.default | 381 | 362 | 1.05:1 |
| MenuMinimalPerf.default | 967 | 917 | 1.05:1 |
| TextAreaMinimalPerf.default | 599 | 572 | 1.05:1 |
| CarouselMinimalPerf.default | 532 | 510 | 1.04:1 |
| PortalMinimalPerf.default | 173 | 167 | 1.04:1 |
| TextMinimalPerf.default | 384 | 368 | 1.04:1 |
| ToolbarMinimalPerf.default | 1107 | 1067 | 1.04:1 |
| DropdownManyItemsPerf.default | 786 | 760 | 1.03:1 |
| HeaderMinimalPerf.default | 407 | 397 | 1.03:1 |
| LabelMinimalPerf.default | 432 | 420 | 1.03:1 |
| ListMinimalPerf.default | 582 | 566 | 1.03:1 |
| IconMinimalPerf.default | 718 | 696 | 1.03:1 |
| BoxMinimalPerf.default | 368 | 362 | 1.02:1 |
| ButtonSlotsPerf.default | 614 | 601 | 1.02:1 |
| DividerMinimalPerf.default | 386 | 378 | 1.02:1 |
| ImageMinimalPerf.default | 423 | 415 | 1.02:1 |
| InputMinimalPerf.default | 1409 | 1378 | 1.02:1 |
| ItemLayoutMinimalPerf.default | 1349 | 1329 | 1.02:1 |
| ListCommonPerf.default | 725 | 713 | 1.02:1 |
| ListNestedPerf.default | 630 | 616 | 1.02:1 |
| MenuButtonMinimalPerf.default | 1900 | 1861 | 1.02:1 |
| PopupMinimalPerf.default | 670 | 659 | 1.02:1 |
| ProviderMinimalPerf.default | 410 | 403 | 1.02:1 |
| SkeletonMinimalPerf.default | 382 | 376 | 1.02:1 |
| CustomToolbarPrototype.default | 2916 | 2862 | 1.02:1 |
| DropdownMinimalPerf.default | 3257 | 3231 | 1.01:1 |
| EmbedMinimalPerf.default | 4539 | 4481 | 1.01:1 |
| TableManyItemsPerf.default | 2183 | 2170 | 1.01:1 |
| TooltipMinimalPerf.default | 1314 | 1301 | 1.01:1 |
| AlertMinimalPerf.default | 296 | 296 | 1:1 |
| AvatarMinimalPerf.default | 205 | 206 | 1:1 |
| ChatDuplicateMessagesPerf.default | 320 | 321 | 1:1 |
| ChatMinimalPerf.default | 819 | 817 | 1:1 |
| CheckboxMinimalPerf.default | 2924 | 2925 | 1:1 |
| DatepickerMinimalPerf.default | 6185 | 6168 | 1:1 |
| FlexMinimalPerf.default | 304 | 303 | 1:1 |
| RosterPerf.default | 1248 | 1249 | 1:1 |
| RadioGroupMinimalPerf.default | 504 | 503 | 1:1 |
| SliderMinimalPerf.default | 1852 | 1846 | 1:1 |
| StatusMinimalPerf.default | 747 | 750 | 1:1 |
| TreeMinimalPerf.default | 903 | 904 | 1:1 |
| ButtonMinimalPerf.default | 184 | 185 | 0.99:1 |
| ButtonOverridesMissPerf.default | 1649 | 1659 | 0.99:1 |
| ChatWithPopoverPerf.default | 422 | 427 | 0.99:1 |
| SplitButtonMinimalPerf.default | 4841 | 4893 | 0.99:1 |
| TreeWith60ListItems.default | 189 | 191 | 0.99:1 |
| DialogMinimalPerf.default | 822 | 836 | 0.98:1 |
| HeaderSlotsPerf.default | 856 | 874 | 0.98:1 |
| LoaderMinimalPerf.default | 738 | 751 | 0.98:1 |
| ProviderMergeThemesPerf.default | 1293 | 1325 | 0.98:1 |
| VideoMinimalPerf.default | 732 | 750 | 0.98:1 |
| AnimationMinimalPerf.default | 583 | 602 | 0.97:1 |
| AttachmentSlotsPerf.default | 1185 | 1226 | 0.97:1 |
| FormMinimalPerf.default | 465 | 483 | 0.96:1 |
| TableMinimalPerf.default | 429 | 463 | 0.93:1 |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 945 | 949 | 5000 | |
| Breadcrumb | mount | 2796 | 2806 | 1000 | |
| Checkbox | mount | 1542 | 1536 | 5000 | |
| CheckboxBase | mount | 1328 | 1347 | 5000 | |
| ChoiceGroup | mount | 4878 | 5016 | 5000 | |
| ComboBox | mount | 1006 | 1044 | 1000 | |
| CommandBar | mount | 10894 | 10893 | 1000 | |
| ContextualMenu | mount | 11849 | 11962 | 1000 | |
| DefaultButton | mount | 1162 | 1170 | 5000 | |
| DetailsRow | mount | 3934 | 4012 | 5000 | |
| DetailsRowFast | mount | 4076 | 4020 | 5000 | |
| DetailsRowNoStyles | mount | 3854 | 3758 | 5000 | |
| Dialog | mount | 2345 | 2272 | 1000 | |
| DocumentCardTitle | mount | 175 | 181 | 1000 | |
| Dropdown | mount | 3422 | 3364 | 5000 | |
| FocusTrapZone | mount | 1951 | 1973 | 5000 | |
| FocusZone | mount | 1918 | 1829 | 5000 | |
| IconButton | mount | 1841 | 1843 | 5000 | |
| Label | mount | 367 | 365 | 5000 | |
| Layer | mount | 3040 | 3116 | 5000 | |
| Link | mount | 496 | 489 | 5000 | |
| MenuButton | mount | 1535 | 1543 | 5000 | |
| MessageBar | mount | 2249 | 2169 | 5000 | |
| Nav | mount | 3444 | 3468 | 1000 | |
| OverflowSet | mount | 1120 | 1109 | 5000 | |
| Panel | mount | 2282 | 2382 | 1000 | |
| Persona | mount | 1041 | 1043 | 1000 | |
| Pivot | mount | 1491 | 1499 | 1000 | |
| PrimaryButton | mount | 1288 | 1342 | 5000 | |
| Rating | mount | 7975 | 7867 | 5000 | |
| SearchBox | mount | 1383 | 1401 | 5000 | |
| Shimmer | mount | 2539 | 2542 | 5000 | |
| Slider | mount | 1995 | 2004 | 5000 | |
| SpinButton | mount | 5234 | 5241 | 5000 | |
| Spinner | mount | 484 | 434 | 5000 | |
| SplitButton | mount | 3334 | 3306 | 5000 | |
| Stack | mount | 548 | 554 | 5000 | |
| StackWithIntrinsicChildren | mount | 2325 | 2339 | 5000 | |
| StackWithTextChildren | mount | 5417 | 5467 | 5000 | |
| SwatchColorPicker | mount | 11995 | 11932 | 5000 | |
| TagPicker | mount | 2787 | 2813 | 5000 | |
| TeachingBubble | mount | 97213 | 96752 | 5000 | |
| Text | mount | 446 | 449 | 5000 | |
| TextField | mount | 1489 | 1509 | 5000 | |
| ThemeProvider | mount | 1263 | 1234 | 5000 | |
| ThemeProvider | virtual-rerender | 648 | 669 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1996 | 2018 | 5000 | |
| Toggle | mount | 813 | 816 | 5000 | |
| buttonNative | mount | 124 | 124 | 5000 |
TristanWatanabe
commented
May 4, 2022
|
|
||
| const first = actual[0]; | ||
| expect(first.startsWith('../../../react-')).toBeTruthy(); | ||
| expect(first.startsWith('../../react-')).toBeTruthy(); |
Member
Author
There was a problem hiding this comment.
This test always results in first being react-accordion therefore the expected path needs to be updated to account for accordion being moved in this PR.
Contributor
There was a problem hiding this comment.
shame on me :D not the most robust test indeed but there were not many options. ty
TristanWatanabe
requested review from
a team,
JustSlone,
behowell and
jurokapsiar
as code owners
ling1726
approved these changes
May 4, 2022
khmakoto
approved these changes
May 5, 2022
JustSlone
approved these changes
May 5, 2022
This reverts commit ad55b96.
TristanWatanabe
changed the title
Member
Author
|
Pulling |
Hotell
approved these changes
May 13, 2022
micahgodbolt
approved these changes
May 18, 2022
marwan38
pushed a commit
to marwan38/fluentui
that referenced
this pull request
Jun 13, 2022
…lder (microsoft#22827) * move react-divider * move react-accordion * move react-badge * Change Files * update test to account for react-accordion move * Change File * Revert "move react-badge" This reverts commit ad55b96. * remove badge changfile * Revert "move react-divider" This reverts commit cf8a10b. * Revert "move react-accordion" This reverts commit 2259ee3. * move react-accordion * move react-divider
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
@fluentui/react-accordion, and@fluentui/react-dividerto react-components common folder usingmove-packagesnx generator.Related Issue(s)
Part of #22427